From: Chris Sosnin <k.sosnin@tarantool.org>
To: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH 0/2] tuple: fixes for update()
Date: Fri, 10 Jan 2020 10:28:24 +0300 [thread overview]
Message-ID: <cover.1578640624.git.k.sosnin@tarantool.org> (raw)
As Nikita suggested, I split the initial patch into the following two.
It already has LGTM from Vlad.
branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-3884-update-error
issue: https://github.com/tarantool/tarantool/issues/3884
Chris Sosnin (2):
tuple: fix non-informative update() error message
tuple: add argument length check for update()
src/box/errcode.h | 2 +-
src/box/xrow_update.c | 4 +--
src/box/xrow_update_field.c | 25 +++++++++++++------
src/box/xrow_update_field.h | 3 ++-
...1-access-settings-from-any-frontend.result | 9 ++++---
test/box/update.result | 18 +++++++++++--
test/box/update.test.lua | 3 +++
test/engine/upsert.result | 13 ++++++----
test/vinyl/gh.result | 3 ++-
9 files changed, 57 insertions(+), 23 deletions(-)
--
2.21.0 (Apple Git-122.2)
next reply other threads:[~2020-01-10 7:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 7:28 Chris Sosnin [this message]
2020-01-10 7:28 ` [Tarantool-patches] [PATCH 1/2] tuple: fix non-informative update() error message Chris Sosnin
2020-01-10 7:28 ` [Tarantool-patches] [PATCH 2/2] tuple: add argument length check for update() Chris Sosnin
2020-01-13 14:18 ` [Tarantool-patches] [PATCH 0/2] tuple: fixes " Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1578640624.git.k.sosnin@tarantool.org \
--to=k.sosnin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/2] tuple: fixes for update()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox