Tarantool development patches archive
 help / color / mirror / Atom feed
From: Ilya Kosarev <i.kosarev@tarantool.org>
To: tarantool-patches@dev.tarantool.org
Cc: v.shpilevoy@tarantool.org
Subject: [Tarantool-patches] [PATCH 0/2] fix vlock obtainment on join & join_vclock test
Date: Mon, 30 Dec 2019 20:46:59 +0300	[thread overview]
Message-ID: <cover.1577726517.git.i.kosarev@tarantool.org> (raw)

First patch fixes vclock obtainment on join for master, as far as in
case of high load vclock used to join replica could be in advance
comparing to an actual WAL and therefore replica could have missed some
tuples from master.
Second patch fixes flaky join_vclock test and splits off explicit test
for changes apply order on replica.

Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-4160-fix-join-vclock
Issue: https://github.com/tarantool/tarantool/issues/4160

1st patch is for master. 2nd patch is for all branches.

Ilya Kosarev (2):
  relay: fix vclock obtainment on join
  test: fix and split flaky join_vclock test

 src/box/relay.cc                              |   7 +-
 src/box/vinyl.c                               |   4 +-
 src/box/wal.c                                 |  23 +++-
 src/box/wal.h                                 |   4 +-
 test/replication/join_vclock.result           |  61 ++++++---
 test/replication/join_vclock.test.lua         |  45 ++++---
 test/replication/master1.lua                  |   1 +
 test/replication/replica_apply_order.result   | 121 ++++++++++++++++++
 test/replication/replica_apply_order.test.lua |  48 +++++++
 test/replication/suite.ini                    |   1 -
 10 files changed, 263 insertions(+), 52 deletions(-)
 create mode 120000 test/replication/master1.lua
 create mode 100644 test/replication/replica_apply_order.result
 create mode 100644 test/replication/replica_apply_order.test.lua

-- 
2.17.1

             reply	other threads:[~2019-12-30 17:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-30 17:46 Ilya Kosarev [this message]
2019-12-30 17:47 ` [Tarantool-patches] [PATCH 1/2] relay: fix vclock obtainment on join Ilya Kosarev
2019-12-31  9:11   ` Kirill Yukhin
2019-12-30 17:47 ` [Tarantool-patches] [PATCH 2/2] test: fix and split flaky join_vclock test Ilya Kosarev
2019-12-31  9:12   ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1577726517.git.i.kosarev@tarantool.org \
    --to=i.kosarev@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 0/2] fix vlock obtainment on join & join_vclock test' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox