From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> To: tarantool-patches@dev.tarantool.org, kostja.osipov@gmail.com, imun@tarantool.org Subject: [Tarantool-patches] [PATCH 0/2] Fiber storage leak Date: Sun, 8 Dec 2019 20:28:31 +0100 [thread overview] Message-ID: <cover.1575833120.git.v.shpilevoy@tarantool.org> (raw) The patchset makes fiber.storage be always deleted. Regardless of where was it created - in a fiber born in the Lua land, or in a fiber serving IProto requests and accessing Lua. That removes - a leak occurred each time when fiber storage was created for an IProto request; - a possibility to see previous request's artifacts left in fiber.storage; And makes possible to use fiber.storage as request-local data. Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4662-fiber-storage-leak Issue: https://github.com/tarantool/tarantool/issues/4662 Issue: https://github.com/tarantool/tarantool/issues/3462 Vladislav Shpilevoy (2): fiber: unref fiber.storage via global Lua state fiber: destroy fiber.storage created by iproto src/box/session.cc | 11 ++- src/box/session.h | 7 +- src/box/txn.c | 13 +-- src/box/txn.h | 7 +- src/lib/core/fiber.c | 23 +++-- src/lib/core/fiber.h | 13 ++- src/lib/core/fiber_pool.c | 6 ++ src/lua/fiber.c | 35 ++++++-- test/app/gh-4662-fiber-storage-leak.result | 88 ++++++++++++++++++++ test/app/gh-4662-fiber-storage-leak.test.lua | 43 ++++++++++ 10 files changed, 217 insertions(+), 29 deletions(-) create mode 100644 test/app/gh-4662-fiber-storage-leak.result create mode 100644 test/app/gh-4662-fiber-storage-leak.test.lua -- 2.21.0 (Apple Git-122.2)
next reply other threads:[~2019-12-08 19:28 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-08 19:28 Vladislav Shpilevoy [this message] 2019-12-08 19:28 ` [Tarantool-patches] [PATCH 1/2] fiber: unref fiber.storage via global Lua state Vladislav Shpilevoy 2019-12-11 23:57 ` Igor Munkin 2019-12-12 8:50 ` Konstantin Osipov 2019-12-12 23:38 ` Vladislav Shpilevoy 2019-12-13 10:44 ` Igor Munkin 2019-12-08 19:28 ` [Tarantool-patches] [PATCH 2/2] fiber: destroy fiber.storage created by iproto Vladislav Shpilevoy 2019-12-09 7:21 ` Konstantin Osipov 2019-12-09 23:31 ` Vladislav Shpilevoy 2019-12-10 8:21 ` Konstantin Osipov 2019-12-10 8:32 ` Konstantin Osipov 2019-12-10 22:59 ` Vladislav Shpilevoy 2019-12-11 7:08 ` Konstantin Osipov 2019-12-11 21:23 ` Vladislav Shpilevoy 2019-12-12 0:00 ` Igor Munkin 2019-12-12 23:37 ` Vladislav Shpilevoy 2019-12-13 13:35 ` Igor Munkin 2019-12-12 8:46 ` Konstantin Osipov 2019-12-13 0:02 ` Vladislav Shpilevoy 2019-12-13 7:58 ` Konstantin Osipov 2019-12-13 23:11 ` Vladislav Shpilevoy 2019-12-14 12:26 ` Konstantin Osipov 2019-12-14 12:30 ` Konstantin Osipov 2019-12-14 12:33 ` Konstantin Osipov 2019-12-14 16:49 ` Vladislav Shpilevoy 2019-12-14 20:59 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1575833120.git.v.shpilevoy@tarantool.org \ --to=v.shpilevoy@tarantool.org \ --cc=imun@tarantool.org \ --cc=kostja.osipov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 0/2] Fiber storage leak' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox