From: Ilya Kosarev <i.kosarev@tarantool.org>
To: tarantool-patches@dev.tarantool.org
Cc: v.shpilevoy@tarantool.org
Subject: [Tarantool-patches] [PATCH 0/3] Safe allocation on truncation and deletion
Date: Fri, 13 Dec 2019 10:05:08 +0300 [thread overview]
Message-ID: <cover.1575627361.git.i.kosarev@tarantool.org> (raw)
space:truncate() and space:delete() could fail on memory allocations
when reaching memtx_memory limit. As far as it is quite an ill
behaviour, it is fixed in this patchset through denial of extra
memory reservation and unconstrained allocation of service tuples
in BOX_TRUNCATE_ID space.
Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-3807-safe-alloc-on-truncation
Issue: https://github.com/tarantool/tarantool/issues/3807
Ilya Kosarev (3):
b-tree: return NULL on matras_alloc fail
memtx: don't reserve extra memory if not needed
tuple: use calloc for service truncation tuples
src/box/memtx_engine.c | 50 ++++++++++++++++++++++++++--------------
src/box/memtx_engine.h | 2 +-
src/box/memtx_space.c | 34 ++++++++++++++++++++-------
src/box/tuple.c | 16 +++++++++----
src/box/tuple.h | 2 +-
src/box/tuple_format.c | 1 +
src/box/tuple_format.h | 10 +++++++-
src/box/vy_stmt.c | 3 ++-
src/lib/salad/bps_tree.h | 2 ++
9 files changed, 87 insertions(+), 33 deletions(-)
--
2.17.1
next reply other threads:[~2019-12-13 7:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 7:05 Ilya Kosarev [this message]
2019-12-13 7:05 ` [Tarantool-patches] [PATCH 1/3] b-tree: return NULL on matras_alloc fail Ilya Kosarev
2019-12-19 0:32 ` Vladislav Shpilevoy
2019-12-13 7:05 ` [Tarantool-patches] [PATCH 2/3] memtx: don't reserve extra memory if not needed Ilya Kosarev
2019-12-19 0:31 ` Vladislav Shpilevoy
2019-12-13 7:05 ` [Tarantool-patches] [PATCH 3/3] tuple: use calloc for service truncation tuples Ilya Kosarev
2019-12-19 0:31 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1575627361.git.i.kosarev@tarantool.org \
--to=i.kosarev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/3] Safe allocation on truncation and deletion' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox