From: Nikita Pettik <korablev@tarantool.org> To: tarantool-patches@dev.tarantool.org Cc: v.shpilevoy@tarantool.org Subject: [Tarantool-patches] [PATCH v2 00/16] sql: prepared statements Date: Thu, 21 Nov 2019 00:27:59 +0300 [thread overview] Message-ID: <cover.1574277369.git.korablev@tarantool.org> (raw) Branch: https://github.com/tarantool/tarantool/tree/np/gh-2592-prepared-statemets-v2 Issue: https://github.com/tarantool/tarantool/issues/2592 Patch v1: https://lists.tarantool.org/pipermail/tarantool-patches/2019-November/012274.html Changes in this iteration: - Now cache is global and statements are shared among all session (main reason for this change is to increase performance); - Cache follows next eviction policy: when there's no space for another one statement, statement which was prepared earlier than others is removed from cache (strickly speaking it's not LRU policy, but rather FIFO; however, the same approach is already used for tuple cache and it is called LRU anyway); - Owing to the previous point, there's no need in 'unprepare' invocation at all (it concerns both manual request and on_disconnect clean-up); - Also due to using replacement policy eviction from cache should not be "visible" to user, i.e. statement should still be capable of being executed. Keeping only numeric ids doesn't allow this, so now we use string ids (which consist of original SQL request); - Statement is automatically re-prepared (on demand) if it is expired as a result of DDL request; - In case statement is busy (is executed right now by other session), it is compiled from scratch and then executed. Nikita Pettik (16): sql: remove sql_prepare_v2() sql: refactor sql_prepare() and sqlPrepare() sql: move sql_prepare() declaration to box/execute.h sql: rename sqlPrepare() to sql_compile() sql: move sql_finalize() to execute.h port: increase padding of struct port port: add dump format and request type to port_sql sql: resurrect sql_bind_parameter_count() function sql: resurrect sql_bind_parameter_name() sql: add sql_stmt_schema_version() sql: introduce sql_stmt_sizeof() function box: increment schema_version on ddl operations sql: introduce sql_stmt_query_str() method sql: introduce cache for prepared statemets box: introduce prepared statements netbox: introduce prepared statements src/box/CMakeLists.txt | 1 + src/box/alter.cc | 3 + src/box/box.cc | 20 ++ src/box/box.h | 1 + src/box/ck_constraint.c | 1 + src/box/errcode.h | 1 + src/box/execute.c | 213 ++++++++++++++- src/box/execute.h | 51 ++++ src/box/iproto.cc | 25 +- src/box/iproto_constants.c | 6 +- src/box/iproto_constants.h | 4 + src/box/lua/cfg.cc | 12 + src/box/lua/execute.c | 161 ++++++++++- src/box/lua/execute.h | 2 +- src/box/lua/init.c | 2 +- src/box/lua/load_cfg.lua | 3 + src/box/lua/net_box.c | 79 ++++++ src/box/lua/net_box.lua | 13 + src/box/prep_stmt.c | 186 +++++++++++++ src/box/prep_stmt.h | 112 ++++++++ src/box/session.cc | 1 + src/box/sql.c | 3 + src/box/sql/analyze.c | 16 +- src/box/sql/legacy.c | 3 +- src/box/sql/prepare.c | 56 +--- src/box/sql/sqlInt.h | 44 +-- src/box/sql/vdbe.h | 2 +- src/box/sql/vdbeInt.h | 1 - src/box/sql/vdbeapi.c | 95 +++++-- src/box/sql/vdbeaux.c | 5 +- src/box/xrow.c | 2 +- src/box/xrow.h | 2 +- src/lib/core/port.h | 2 +- test/app-tap/init_script.result | 37 +-- test/box/admin.result | 2 + test/box/cfg.result | 7 + test/box/cfg.test.lua | 1 + test/box/misc.result | 3 + test/sql/engine.cfg | 4 + test/sql/prepared.result | 592 ++++++++++++++++++++++++++++++++++++++++ test/sql/prepared.test.lua | 227 +++++++++++++++ 41 files changed, 1851 insertions(+), 150 deletions(-) create mode 100644 src/box/prep_stmt.c create mode 100644 src/box/prep_stmt.h create mode 100644 test/sql/prepared.result create mode 100644 test/sql/prepared.test.lua -- 2.15.1
next reply other threads:[~2019-11-20 21:28 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-20 21:27 Nikita Pettik [this message] 2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 01/16] sql: remove sql_prepare_v2() Nikita Pettik 2019-12-04 11:36 ` Konstantin Osipov 2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 02/16] sql: refactor sql_prepare() and sqlPrepare() Nikita Pettik 2019-12-03 22:51 ` Vladislav Shpilevoy 2019-12-04 11:36 ` Konstantin Osipov 2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 03/16] sql: move sql_prepare() declaration to box/execute.h Nikita Pettik 2019-12-04 11:37 ` Konstantin Osipov 2019-12-05 13:32 ` Nikita Pettik 2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 04/16] sql: rename sqlPrepare() to sql_compile() Nikita Pettik 2019-12-03 22:51 ` Vladislav Shpilevoy 2019-12-13 13:49 ` Nikita Pettik 2019-12-04 11:39 ` Konstantin Osipov 2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 05/16] sql: move sql_finalize() to execute.h Nikita Pettik 2019-12-03 22:51 ` Vladislav Shpilevoy 2019-12-04 11:39 ` Konstantin Osipov 2019-12-13 13:49 ` Nikita Pettik 2019-12-04 11:40 ` Konstantin Osipov 2019-12-05 13:37 ` Nikita Pettik 2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 06/16] port: increase padding of struct port Nikita Pettik 2019-12-04 11:42 ` Konstantin Osipov 2019-12-13 13:54 ` Nikita Pettik 2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 07/16] port: add dump format and request type to port_sql Nikita Pettik 2019-12-03 22:51 ` Vladislav Shpilevoy 2019-12-13 13:55 ` Nikita Pettik 2019-12-04 11:52 ` Konstantin Osipov 2019-12-13 13:53 ` Nikita Pettik 2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 08/16] sql: resurrect sql_bind_parameter_count() function Nikita Pettik 2019-12-03 22:51 ` Vladislav Shpilevoy 2019-12-04 11:54 ` Konstantin Osipov 2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 09/16] sql: resurrect sql_bind_parameter_name() Nikita Pettik 2019-12-04 11:55 ` Konstantin Osipov 2019-12-04 11:55 ` Konstantin Osipov 2019-12-13 13:55 ` Nikita Pettik 2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 10/16] sql: add sql_stmt_schema_version() Nikita Pettik 2019-12-04 11:57 ` Konstantin Osipov 2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 11/16] sql: introduce sql_stmt_sizeof() function Nikita Pettik 2019-12-03 22:51 ` Vladislav Shpilevoy 2019-12-13 13:56 ` Nikita Pettik 2019-12-04 11:59 ` Konstantin Osipov 2019-12-13 13:56 ` Nikita Pettik 2019-12-13 14:15 ` Konstantin Osipov 2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 12/16] box: increment schema_version on ddl operations Nikita Pettik 2019-12-04 12:03 ` Konstantin Osipov 2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 13/16] sql: introduce sql_stmt_query_str() method Nikita Pettik 2019-12-03 22:51 ` Vladislav Shpilevoy 2019-12-04 12:04 ` Konstantin Osipov 2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 14/16] sql: introduce cache for prepared statemets Nikita Pettik 2019-12-03 22:51 ` Vladislav Shpilevoy 2019-12-04 12:11 ` Konstantin Osipov 2019-12-17 14:43 ` Kirill Yukhin 2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 15/16] box: introduce prepared statements Nikita Pettik 2019-12-04 12:13 ` Konstantin Osipov 2019-12-06 23:18 ` Vladislav Shpilevoy 2019-11-20 21:28 ` [Tarantool-patches] [PATCH v2 16/16] netbox: " Nikita Pettik 2019-12-06 23:18 ` Vladislav Shpilevoy 2019-12-03 22:51 ` [Tarantool-patches] [PATCH v2 00/16] sql: " Vladislav Shpilevoy 2019-12-17 15:58 ` Georgy Kirichenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1574277369.git.korablev@tarantool.org \ --to=korablev@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v2 00/16] sql: prepared statements' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox