Tarantool development patches archive
 help / color / mirror / Atom feed
From: Serge Petrenko <sergepetrenko@tarantool.org>
To: v.shpilevoy@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v3 0/3] fiber.top(): minor fixup
Date: Mon, 18 Nov 2019 19:05:02 +0300	[thread overview]
Message-ID: <cover.1574091776.git.sergepetrenko@tarantool.org> (raw)

The first patch factors all the clock-related members of struct fiber and struct
cord into appropriate structs and adds methods for their updates and resets.

The second patch fixes exponential moving average calculation so that we do not
experience huge numbers in average load percentage calculations.

The third patch alters fiber.top() test to wait for correct output before
testing it. 

Follow-up https://github.com/tarantool/tarantool/issues/2694
Branch https://github.com/tarantool/tarantool/tree/sp/gh-2694-test-fixup

Changes in v3:
 - introduce a new patch which refactors all the clock stat
   handling.
 - introduce a patch fixing EMA calculation
 - review fixes as per review from Vladislav

Changes in v2:
 - clean up all fibers clock stats on fiber.top_enable()
 - push 0 instead of NaN when cord clock_delta_last is 0
 - review fixes as per review from Vladislav

Serge Petrenko (3):
  fiber.top() refactor clock and cpu time calculation
  fiber.top(): alter exponential moving average calculation
  app/fiber: wait till a full event loop iteration ends

 src/lib/core/fiber.c    | 175 ++++++++++++++++++++++++----------------
 src/lib/core/fiber.h    | 109 +++++++++++++++++--------
 src/lua/fiber.c         |  20 +++--
 test/app/fiber.result   |  38 ++++++---
 test/app/fiber.test.lua |  36 +++++++--
 5 files changed, 252 insertions(+), 126 deletions(-)

-- 
2.21.0 (Apple Git-122)

             reply	other threads:[~2019-11-18 16:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-18 16:05 Serge Petrenko [this message]
2019-11-18 16:05 ` [Tarantool-patches] [PATCH v3 1/3] fiber.top() refactor clock and cpu time calculation Serge Petrenko
2019-11-18 22:25   ` Vladislav Shpilevoy
2019-11-19  7:14     ` Sergey Petrenko
2019-11-18 16:05 ` [Tarantool-patches] [PATCH v3 2/3] fiber.top(): alter exponential moving average calculation Serge Petrenko
2019-11-18 16:05 ` [Tarantool-patches] [PATCH v3 3/3] app/fiber: wait till a full event loop iteration ends Serge Petrenko
2019-11-19 22:57 ` [Tarantool-patches] [PATCH v3 0/3] fiber.top(): minor fixup Vladislav Shpilevoy
2019-11-20  1:44   ` Alexander Turenko
2019-11-20  8:29     ` Serge Petrenko
2019-11-20 12:19       ` Alexander Turenko
2019-11-21 17:07 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1574091776.git.sergepetrenko@tarantool.org \
    --to=sergepetrenko@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v3 0/3] fiber.top(): minor fixup' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox