Tarantool development patches archive
 help / color / mirror / Atom feed
From: Serge Petrenko <sergepetrenko@tarantool.org>
To: v.shpilevoy@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v2 0/2] fiber.top(): minor fixup
Date: Fri, 15 Nov 2019 17:58:57 +0300	[thread overview]
Message-ID: <cover.1573828446.git.sergepetrenko@tarantool.org> (raw)

The first patch fixes variable initialization after fiber.top_enable()
so that cord clocks don't contain garbage on first event loop iteration after
enable.

The second patch alters fiber.top() test to wait for correct output before
testing it. 

Follow-up https://github.com/tarantool/tarantool/issues/2694
Branch https://github.com/tarantool/tarantool/tree/sp/gh-2694-test-fixup

Changes in v2:
  - clean up all fibers clock stats on fiber.top_enable()
  - push 0 instead of NaN when cord clock_delta_last is 0
  - review fixes as per review from Vladislav

Serge Petrenko (2):
  fiber: reset clock stats on fiber.top_enable()
  app/fiber: wait till a full event loop iteration ends

 src/lib/core/fiber.c    | 21 +++++++++++++++++++++
 src/lua/fiber.c         | 12 ++++++++++--
 test/app/fiber.result   | 28 +++++++++++++++++++---------
 test/app/fiber.test.lua | 26 ++++++++++++++++++--------
 4 files changed, 68 insertions(+), 19 deletions(-)

-- 
2.21.0 (Apple Git-122)

             reply	other threads:[~2019-11-15 14:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-15 14:58 Serge Petrenko [this message]
2019-11-15 14:58 ` [Tarantool-patches] [PATCH v2 1/2] fiber: reset clock stats on fiber.top_enable() Serge Petrenko
2019-11-15 16:11   ` Alexander Turenko
2019-11-15 18:23     ` Serge Petrenko
2019-11-15 21:39   ` Vladislav Shpilevoy
2019-11-18 16:11     ` Serge Petrenko
2019-11-15 14:58 ` [Tarantool-patches] [PATCH v2 2/2] app/fiber: wait till a full event loop iteration ends Serge Petrenko
2019-11-15 15:35   ` Serge Petrenko
2019-11-15 16:27   ` Alexander Turenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1573828446.git.sergepetrenko@tarantool.org \
    --to=sergepetrenko@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v2 0/2] fiber.top(): minor fixup' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox