Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@dev.tarantool.org, kostja.osipov@gmail.com
Subject: [Tarantool-patches] [PATCH 0/3] Replication status errno
Date: Tue,  5 Nov 2019 17:59:49 +0300	[thread overview]
Message-ID: <cover.1572965692.git.v.shpilevoy@tarantool.org> (raw)

The patchset makes box.info.replication*.upstream/downstream show
errno description for system errors.

I made that it shows strerror(errno) of the latest system error,
but probably it would be better to show errno value, and let a
user to translate it manually using Lua errno module. On the other
hand my way is simpler for a user when he manually calls box.info
in a console to check a replication status. That is discussable.

Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4402-replication-system-error
Issue: https://github.com/tarantool/tarantool/issues/4402

Vladislav Shpilevoy (3):
  access: fix invalid error type for not found user
  error: move errno into an error object
  replication: show errno in replication info

 src/box/applier.cc                           |  2 +-
 src/box/lua/info.c                           | 29 +++++----
 src/box/schema.cc                            |  5 +-
 src/box/user.cc                              |  5 +-
 src/lib/core/diag.c                          |  1 +
 src/lib/core/diag.h                          |  6 ++
 src/lib/core/exception.cc                    | 22 +++----
 src/lib/core/exception.h                     |  5 --
 src/lua/error.lua                            | 10 ++++
 test/box/access.result                       |  3 +-
 test/box/misc.result                         | 19 ++++++
 test/box/misc.test.lua                       | 10 ++++
 test/replication/gh-4402-info-errno.result   | 63 ++++++++++++++++++++
 test/replication/gh-4402-info-errno.test.lua | 25 ++++++++
 test/replication/suite.cfg                   |  1 +
 15 files changed, 170 insertions(+), 36 deletions(-)
 create mode 100644 test/replication/gh-4402-info-errno.result
 create mode 100644 test/replication/gh-4402-info-errno.test.lua

-- 
2.21.0 (Apple Git-122.2)

             reply	other threads:[~2019-11-05 14:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05 14:59 Vladislav Shpilevoy [this message]
2019-11-05 14:59 ` [Tarantool-patches] [PATCH 1/3] access: fix invalid error type for not found user Vladislav Shpilevoy
2019-11-05 18:15   ` Konstantin Osipov
2019-11-06 14:48     ` Vladislav Shpilevoy
2019-11-05 14:59 ` [Tarantool-patches] [PATCH 2/3] error: move errno into an error object Vladislav Shpilevoy
2019-11-05 18:18   ` Konstantin Osipov
2019-11-06 14:49     ` Vladislav Shpilevoy
2019-11-05 14:59 ` [Tarantool-patches] [PATCH 3/3] replication: show errno in replication info Vladislav Shpilevoy
2019-11-05 18:18   ` Konstantin Osipov
2019-11-05 18:13 ` [Tarantool-patches] [PATCH 0/3] Replication status errno Konstantin Osipov
2019-11-21 17:38 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1572965692.git.v.shpilevoy@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=kostja.osipov@gmail.com \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 0/3] Replication status errno' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox