From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH 0/3] JSON preparation part 5
Date: Fri, 1 Nov 2019 00:43:04 +0100 [thread overview]
Message-ID: <cover.1572565151.git.v.shpilevoy@tarantool.org> (raw)
The patchset is a fifth part of preparations to JSON updates of a tuple. It
reorganizes code. Before the path there was one huge file implementing xrow
update. Soon amount of the code will be much larger, and a new code structure
was needed to be able to maintain it. Now xrow update implementation consists of
several files. One file for general update functions and structures, one file
for top-level API used by other tarantool code, and one file per each
non-trivial type of xrow field update.
By the idea, each xrow_update_<type>.c will implement update of one field types
such as array, bar, map, route. It allows to make these implementations
independent and easy to support.
Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-1261-update-json-preparation-5
Issue: https://github.com/tarantool/tarantool/issues/1261
Vladislav Shpilevoy (3):
tuple: move tuple_update into xrow_update/ folder
tuple: rename tuple_update_* to xrow_update_*
tuple: rework updates to improve code extendibility
src/box/CMakeLists.txt | 4 +-
src/box/lua/tuple.c | 9 +-
src/box/memtx_space.c | 26 +-
src/box/space.c | 30 +-
src/box/tuple.c | 11 +-
src/box/tuple.h | 2 +-
src/box/tuple_update.c | 1520 -----------------
src/box/vinyl.c | 22 +-
src/box/vy_upsert.c | 14 +-
src/box/xrow_update/xrow_update.c | 499 ++++++
.../xrow_update.h} | 36 +-
src/box/xrow_update/xrow_update_array.c | 302 ++++
src/box/xrow_update/xrow_update_field.c | 665 ++++++++
src/box/xrow_update/xrow_update_field.h | 442 +++++
test/box/tuple.result | 4 +-
test/unit/column_mask.c | 8 +-
16 files changed, 1991 insertions(+), 1603 deletions(-)
delete mode 100644 src/box/tuple_update.c
create mode 100644 src/box/xrow_update/xrow_update.c
rename src/box/{tuple_update.h => xrow_update/xrow_update.h} (70%)
create mode 100644 src/box/xrow_update/xrow_update_array.c
create mode 100644 src/box/xrow_update/xrow_update_field.c
create mode 100644 src/box/xrow_update/xrow_update_field.h
--
2.21.0 (Apple Git-122.2)
next reply other threads:[~2019-10-31 23:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 23:43 Vladislav Shpilevoy [this message]
2019-10-31 23:43 ` [Tarantool-patches] [PATCH 1/3] tuple: move tuple_update into xrow_update/ folder Vladislav Shpilevoy
2019-11-04 17:26 ` Konstantin Osipov
2019-11-06 15:14 ` Vladislav Shpilevoy
2019-10-31 23:43 ` [Tarantool-patches] [PATCH 2/3] tuple: rename tuple_update_* to xrow_update_* Vladislav Shpilevoy
2019-11-04 17:26 ` Konstantin Osipov
2019-10-31 23:43 ` [Tarantool-patches] [PATCH 3/3] tuple: rework updates to improve code extendibility Vladislav Shpilevoy
2019-11-04 17:36 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1572565151.git.v.shpilevoy@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/3] JSON preparation part 5' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox