Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v2 0/2] Fix build problems on FreeBSD and Mac OS
Date: Sat, 26 Oct 2019 04:01:57 +0300	[thread overview]
Message-ID: <cover.1572050052.git.alexander.turenko@tarantool.org> (raw)

This patchset fixes two problems with building of tarantool on different
OSes:

- https://github.com/tarantool/tarantool/issues/4490
  "FreeBSD compilation failing due to curl dependencies"
- https://github.com/tarantool/tarantool/issues/4587
  "build: failed to link on MacOS with GNU binutils in PATH"

The first patch handles several problems with our libcurl build that we
observes on FreeBSD. In brief, it ensures that we use the same OpenSSL
library and headers as for tarantool's crypto module as well as for
libcurl build and also ensures that the headers and the library are from
the same 'prefix' directory. Those changes reveal several other build
problems (including one on Mac OS) and I fixed them within this patch.

The second patch fixes the problem on Mac OS when different toolchains
can be choosen for building tarantool, libluajit.a and libcurl.a. It is
not a side effect of the first patch: current master is affected too.

I already sent the first patch, but decided to investigate the new
problem on Mac OS and base the fix on the work that was done for
FreeBSD. The first patch got LGTMs from Igor M. and Alexander Tikh. and
was not changed except one comment that clarifies why LIBCURL_CFLAGS /
LIBCURL_CPPFLAGS contain only -isysroot=<SDK_PATH> option.

The patchset is here:

https://github.com/tarantool/tarantool/commits/Totktonada/gh-4490-fix-freebsd-openssl-linking-problems-full-ci

Alexander Turenko (2):
  build: fix OpenSSL linking problems on FreeBSD
  build: pass path to toolchain for luajit and curl

 cmake/BuildLibCURL.cmake | 42 +++++++++++++++++++++++++++++++++-------
 cmake/compiler.cmake     |  4 +++-
 cmake/luajit.cmake       | 12 ++++++++++++
 cmake/os.cmake           | 35 +++++++++++++++++++++++++++++++++
 4 files changed, 85 insertions(+), 8 deletions(-)

-- 
2.22.0

             reply	other threads:[~2019-10-26  1:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-26  1:01 Alexander Turenko [this message]
2019-10-26  1:01 ` [Tarantool-patches] [PATCH v2 1/2] build: fix OpenSSL linking problems on FreeBSD Alexander Turenko
2019-10-26  1:01 ` [Tarantool-patches] [PATCH v2 2/2] build: pass path to toolchain for luajit and curl Alexander Turenko
2019-10-28  7:16 ` [Tarantool-patches] [PATCH v2 0/2] Fix build problems on FreeBSD and Mac OS Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1572050052.git.alexander.turenko@tarantool.org \
    --to=alexander.turenko@tarantool.org \
    --cc=imun@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [Tarantool-patches] [PATCH v2 0/2] Fix build problems on FreeBSD and Mac OS' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox