Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@dev.tarantool.org, tarantool-patches@freelists.org
Subject: [Tarantool-patches] [PATCH 0/2] JSON update pre-preparation
Date: Sat, 26 Oct 2019 00:53:47 +0200	[thread overview]
Message-ID: <cover.1572043528.git.v.shpilevoy@tarantool.org> (raw)

The patchset is a preparation for the JSON update preparation.

The main commit is the second one. It renames internals of
tuple_update.c from update_* to xrow_update_*.

Why it is done - see the commit message.

After we decide on naming of update structures and functions, I
will rebase the main JSON preparation patch
(gerold103/gh-1261-update-json-preparation-3) on new names.

This patchset is actually an RFC, because I don't like
xrow_update_ prefix. It is bulky, too long, and most of the names,
having it, look unclear.

I would like to either keep update_ prefix, or use xupdate_ - both
are better than xrow_update_, IMO. But actually I don't really
care already, so I will name it whatever helps to push it.

Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-1261-update-json-preparation-4
Issue: https://github.com/tarantool/tarantool/issues/1261

Vladislav Shpilevoy (2):
  rope: fix rope name template
  tuple: rename update to xrow_update in tuple_update.c

 src/box/tuple_update.c | 610 ++++++++++++++++++++++-------------------
 src/lib/salad/rope.h   |  18 +-
 2 files changed, 345 insertions(+), 283 deletions(-)

-- 
2.21.0 (Apple Git-122)

             reply	other threads:[~2019-10-25 22:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-25 22:53 Vladislav Shpilevoy [this message]
2019-10-25 22:53 ` [Tarantool-patches] [PATCH 1/2] rope: fix rope name template Vladislav Shpilevoy
2019-10-28  7:32   ` Konstantin Osipov
2019-10-25 22:53 ` [Tarantool-patches] [PATCH 2/2] tuple: rename update to xrow_update in tuple_update.c Vladislav Shpilevoy
2019-10-28  7:33   ` Konstantin Osipov
2019-10-28  7:52 ` [Tarantool-patches] [tarantool-patches] [PATCH 0/2] JSON update pre-preparation Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1572043528.git.v.shpilevoy@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [Tarantool-patches] [PATCH 0/2] JSON update pre-preparation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox