From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org
Cc: alexander.turenko@tarantool.org
Subject: [tarantool-patches] [PATCH v2 0/4] Serializer bugs
Date: Tue, 10 Sep 2019 22:24:45 +0200 [thread overview]
Message-ID: <cover.1568055477.git.v.shpilevoy@tarantool.org> (raw)
The patchset fixes several problems about JSON and msgpack serializers.
1) msgpackffi didn't use msgpack serializer options;
2) tuple serializer either;
3) update of a serializer option was not reflected in its Lua representation;
4) during serialization too nested tables are silently cropped and there was no
way to prevent it.
Also it was discovered, that msgpackffi does not care *all* options. Not only
about max_depth. I am not sure if it is worth fixing here (or at all) though.
Changes in v2:
- Renames;
- Default value a flag for whether we need to raise an error on a too nested msgpack (was crop, now error).
Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4434-box-lua-msgpack-cfg
Issue: https://github.com/tarantool/tarantool/issues/4434
Vladislav Shpilevoy (4):
app: serializers update now is reflected in Lua
msgpack: make msgpackffi use encode_max_depth option
tuple: use global msgpack serializer in Lua tuple
app: allow to raise an error on too nested tables
src/box/lua/tuple.c | 33 +++++++++++++-----
src/lua/msgpack.c | 4 +++
src/lua/msgpackffi.lua | 6 ++--
src/lua/utils.c | 47 +++++++++++++++----------
src/lua/utils.h | 32 +++++++++++++++++
test/app-tap/json.test.lua | 3 +-
test/app-tap/lua/serializer_test.lua | 31 +++++++++++++++++
test/app-tap/msgpack.test.lua | 3 +-
test/app-tap/msgpackffi.test.lua | 31 ++++++++++++++++-
test/box/tuple.result | 52 ++++++++++++++++++++++++++++
test/box/tuple.test.lua | 23 ++++++++++++
test/unit/luaT_tuple_new.c | 2 +-
third_party/lua-cjson/lua_cjson.c | 10 ++++--
13 files changed, 243 insertions(+), 34 deletions(-)
--
2.20.1 (Apple Git-117)
next reply other threads:[~2019-09-10 20:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 20:24 Vladislav Shpilevoy [this message]
2019-09-09 19:00 ` [tarantool-patches] [PATCH v2 1/4] app: serializers update now is reflected in Lua Vladislav Shpilevoy
2019-09-12 23:22 ` [tarantool-patches] " Alexander Turenko
2019-09-13 22:32 ` Vladislav Shpilevoy
2019-09-09 19:00 ` [tarantool-patches] [PATCH v2 2/4] msgpack: make msgpackffi use encode_max_depth option Vladislav Shpilevoy
2019-09-12 23:24 ` [tarantool-patches] " Alexander Turenko
2019-09-13 22:32 ` Vladislav Shpilevoy
2019-09-09 19:00 ` [tarantool-patches] [PATCH v2 3/4] tuple: use global msgpack serializer in Lua tuple Vladislav Shpilevoy
2019-09-12 23:27 ` [tarantool-patches] " Alexander Turenko
2019-09-13 22:32 ` Vladislav Shpilevoy
2019-09-09 19:00 ` [tarantool-patches] [PATCH v2 4/4] app: allow to raise an error on too nested tables Vladislav Shpilevoy
2019-09-12 23:32 ` [tarantool-patches] " Alexander Turenko
2019-09-13 22:32 ` Vladislav Shpilevoy
2019-09-10 20:25 ` [tarantool-patches] Re: [PATCH v2 0/4] Serializer bugs Vladislav Shpilevoy
2019-09-12 23:44 ` Alexander Turenko
2019-09-13 22:32 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1568055477.git.v.shpilevoy@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH v2 0/4] Serializer bugs' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox