Tarantool development patches archive
 help / color / mirror / Atom feed
* [tarantool-patches] [PATCH 0/1] Follow up for string.find recording fix
@ 2019-09-05 17:57 Igor Munkin
  0 siblings, 0 replies; only message in thread
From: Igor Munkin @ 2019-09-05 17:57 UTC (permalink / raw)
  To: tarantool-patches; +Cc: Igor Munkin

The problem is faced only with enabled JIT. Fix provided within
587532e leads to invalid end index of the string being matched
while recording. This offset is biased with the respect to position
the match is initialized instead of the start of the origin string.

Mr. Egorov approved Sergos proposal in his comment
https://github.com/LuaJIT/LuaJIT/issues/505#issuecomment-528482812
and his solution is quite similar to the one I discussed offline
with Sergos.

Branch: https://github.com/tarantool/luajit/tree/imun/fix-string-find-recordiing
Issue: https://github.com/tarantool/tarantool/issues/4476

Igor Munkin (1):
  luajit: fix string.find recording

 src/lj_ffrecord.c                       |  4 +-
 test/fix_string_find_recording.test.lua | 79 +++++++++++++++++++++++++
 2 files changed, 81 insertions(+), 2 deletions(-)
 create mode 100755 test/fix_string_find_recording.test.lua

-- 
2.22.1

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-09-05 17:55 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-05 17:57 [tarantool-patches] [PATCH 0/1] Follow up for string.find recording fix Igor Munkin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox