From: Igor Munkin <imun@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Igor Munkin <imun@tarantool.org>
Subject: [tarantool-patches] [PATCH 0/1] Follow up for string.find recording fix
Date: Thu, 5 Sep 2019 20:57:27 +0300 [thread overview]
Message-ID: <cover.1567704927.git.imun@tarantool.org> (raw)
The problem is faced only with enabled JIT. Fix provided within
587532e leads to invalid end index of the string being matched
while recording. This offset is biased with the respect to position
the match is initialized instead of the start of the origin string.
Mr. Egorov approved Sergos proposal in his comment
https://github.com/LuaJIT/LuaJIT/issues/505#issuecomment-528482812
and his solution is quite similar to the one I discussed offline
with Sergos.
Branch: https://github.com/tarantool/luajit/tree/imun/fix-string-find-recordiing
Issue: https://github.com/tarantool/tarantool/issues/4476
Igor Munkin (1):
luajit: fix string.find recording
src/lj_ffrecord.c | 4 +-
test/fix_string_find_recording.test.lua | 79 +++++++++++++++++++++++++
2 files changed, 81 insertions(+), 2 deletions(-)
create mode 100755 test/fix_string_find_recording.test.lua
--
2.22.1
reply other threads:[~2019-09-05 17:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1567704927.git.imun@tarantool.org \
--to=imun@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH 0/1] Follow up for string.find recording fix' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox