Tarantool development patches archive
 help / color / mirror / Atom feed
From: Ilya Kosarev <i.kosarev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: georgy@tarantool.org, i.kosarev@corp.mail.ru,
	Ilya Kosarev <i.kosarev@tarantool.org>
Subject: [tarantool-patches] [PATCH v2 0/6] refactoring: remove exceptions from triggers
Date: Fri, 16 Aug 2019 21:37:46 +0300	[thread overview]
Message-ID: <cover.1565979897.git.i.kosarev@tarantool.org> (raw)

Triggers don't throw exceptions any more. Now they have
return codes to report errors.

Changes in v2:
1) Patch is divided into parts.
2) Corresponding comments are updated according to code changes.

Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-4247-remove-exceptions-from-triggers 
Issue: https://github.com/tarantool/tarantool/issues/4247

Ilya Kosarev (6):
  refactoring: remove exceptions from triggers except alter.cc
  refactoring: remove exceptions from used in alter.cc outer functions
  refactoring: replace most obvious exceptions in alter.cc
  refactoring: replace exceptions in most alter.cc functions
  refactoring: replace some more exceptions in alter.cc
  refactoring: replace remaining exceptions in alter.cc & update
    comments

 src/box/alter.cc            | 3297 +++++++++++++++++++++--------------
 src/box/applier.cc          |   18 +-
 src/box/ck_constraint.c     |    9 +-
 src/box/ck_constraint.h     |    4 +-
 src/box/identifier.h        |   10 -
 src/box/iproto.cc           |    3 +-
 src/box/lua/call.c          |    5 +-
 src/box/lua/sequence.c      |    3 +-
 src/box/lua/space.cc        |    3 +-
 src/box/memtx_space.c       |   17 +-
 src/box/relay.cc            |    5 +-
 src/box/replication.cc      |  193 +-
 src/box/replication.h       |    2 +-
 src/box/schema.cc           |   28 +-
 src/box/schema.h            |   17 +-
 src/box/sequence.h          |    9 -
 src/box/session.cc          |    3 +-
 src/box/tuple.h             |   69 -
 src/box/txn.c               |   10 +-
 src/box/user.cc             |    9 +-
 src/box/user.h              |   14 +-
 src/box/vinyl.c             |   44 +-
 src/lib/core/fiber.c        |    3 +-
 src/lib/core/trigger.cc     |   23 +-
 src/lib/core/trigger.h      |    2 +-
 src/lua/trigger.c           |    7 +-
 src/main.cc                 |    3 +-
 test/unit/cbus.c            |    3 +-
 test/unit/swim.c            |    6 +-
 test/unit/swim_test_utils.c |    3 +-
 30 files changed, 2240 insertions(+), 1582 deletions(-)

-- 
2.17.1

             reply	other threads:[~2019-08-16 18:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-16 18:37 Ilya Kosarev [this message]
2019-08-16 18:37 ` [tarantool-patches] [PATCH v2 1/6] refactoring: remove exceptions from triggers except alter.cc Ilya Kosarev
2019-08-27  8:29   ` [tarantool-patches] " Georgy Kirichenko
2019-08-16 18:37 ` [tarantool-patches] [PATCH v2 2/6] refactoring: remove exceptions from used in alter.cc outer functions Ilya Kosarev
2019-08-27  8:37   ` [tarantool-patches] " Georgy Kirichenko
2019-08-16 18:37 ` [tarantool-patches] [PATCH v2 3/6] refactoring: replace most obvious exceptions in alter.cc Ilya Kosarev
2019-08-27  8:41   ` [tarantool-patches] " Georgy Kirichenko
2019-09-02 11:53     ` [tarantool-patches] Re[2]: [PATCH v2] refactoring: remove exceptions from triggers Ilya Kosarev
2019-08-16 18:37 ` [tarantool-patches] [PATCH v2 4/6] refactoring: replace exceptions in most alter.cc functions Ilya Kosarev
2019-08-16 18:37 ` [tarantool-patches] [PATCH v2 5/6] refactoring: replace some more exceptions in alter.cc Ilya Kosarev
2019-08-16 18:37 ` [tarantool-patches] [PATCH v2 6/6] refactoring: replace remaining exceptions in alter.cc & update comments Ilya Kosarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1565979897.git.i.kosarev@tarantool.org \
    --to=i.kosarev@tarantool.org \
    --cc=georgy@tarantool.org \
    --cc=i.kosarev@corp.mail.ru \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [tarantool-patches] [PATCH v2 0/6] refactoring: remove exceptions from triggers' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox