From: Nikita Pettik <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org, Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] [PATCH 0/2] Fix border case in float-int comparison in SQL
Date: Wed, 7 Aug 2019 01:02:13 +0300 [thread overview]
Message-ID: <cover.1565120194.git.korablev@tarantool.org> (raw)
Branch: https://github.com/tarantool/tarantool/tree/np/sql-fix-float-int-cmp
This patch makes SQL utilize the same routine to compare integers
with floating point values as in NoSQL.
Nikita Pettik (2):
Move mp_compare_double_uint64() to trivia.h
sql: use double_compare_uint64() for int<->float cmp
src/box/sql/vdbeaux.c | 74 ++++++++++----------------------------------
src/box/tuple_compare.cc | 80 ++----------------------------------------------
src/lib/core/util.c | 63 ++++++++++++++++++++++++++++++++++++++
src/trivia/util.h | 14 +++++++++
test/sql/types.result | 2 +-
5 files changed, 97 insertions(+), 136 deletions(-)
--
2.15.1
next reply other threads:[~2019-08-06 22:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 22:02 Nikita Pettik [this message]
2019-08-06 22:02 ` [tarantool-patches] [PATCH 1/2] Move mp_compare_double_uint64() to trivia.h Nikita Pettik
2019-08-08 21:37 ` [tarantool-patches] ***UNCHECKED*** " Vladislav Shpilevoy
2019-08-14 10:36 ` [tarantool-patches] " n.pettik
2019-08-14 20:43 ` Vladislav Shpilevoy
2019-08-08 21:37 ` [tarantool-patches] ***UNCHECKED*** " Vladislav Shpilevoy
2019-08-06 22:02 ` [tarantool-patches] [PATCH 2/2] sql: use double_compare_uint64() for int<->float cmp Nikita Pettik
2019-08-22 12:31 ` [tarantool-patches] Re: [PATCH 0/2] Fix border case in float-int comparison in SQL Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1565120194.git.korablev@tarantool.org \
--to=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [tarantool-patches] [PATCH 0/2] Fix border case in float-int comparison in SQL' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox