From: imeevma@tarantool.org
To: v.shpilevoy@tarantool.org
Cc: kostja@tarantool.org, tarantool-patches@freelists.org
Subject: [tarantool-patches] [PATCH v2 0/2] sql: rework error handling in box.execute()
Date: Wed, 31 Jul 2019 13:32:19 +0300 [thread overview]
Message-ID: <cover.1564568388.git.imeevma@gmail.com> (raw)
This patch-set reworks the error handling of box.execute(). After
this patch-set, box.execute() will return nil as the first return
value, and error as the second.
https://github.com/tarantool/tarantool/issues/4390
https://github.com/tarantool/tarantool/tree/imeevma/gh-4390-box_execute-should-not-throw
Changes in v2:
- Added function, that pushes nil and error in Lua stack.
Mergen Imeev (2):
lua: new function luaT_return_error()
sql: rework error handling in box.execute()
src/box/lua/execute.c | 4 +-
src/box/lua/session.c | 12 +-
src/lua/error.c | 10 ++
src/lua/error.h | 9 +
src/lua/fio.c | 74 +++------
src/lua/swim.c | 7 +-
test/sql-tap/gh2548-select-compound-limit.test.lua | 10 +-
test/sql-tap/lua/sqltester.lua | 5 +-
test/sql/bind.result | 14 +-
test/sql/bind.test.lua | 8 +-
test/sql/checks.result | 52 ++++--
test/sql/clear.result | 9 +-
test/sql/collation.result | 63 ++++---
test/sql/delete.result | 19 ++-
test/sql/drop-table.result | 16 +-
test/sql/errinj.result | 54 ++++--
test/sql/foreign-keys.result | 27 +--
test/sql/gh-2929-primary-key.result | 15 +-
test/sql/gh-2981-check-autoinc.result | 12 +-
test/sql/gh-3613-idx-alter-update.result | 3 +-
test/sql/gh-3888-values-blob-assert.result | 18 +-
test/sql/icu-upper-lower.result | 9 +-
test/sql/insert-unique.result | 6 +-
test/sql/integer-overflow.result | 28 ++--
test/sql/message-func-indexes.result | 12 +-
test/sql/misc.result | 31 ++--
test/sql/no-pk-space.result | 15 +-
test/sql/on-conflict.result | 38 +++--
test/sql/persistency.result | 12 +-
test/sql/row-count.result | 3 +-
test/sql/savepoints.result | 16 +-
test/sql/savepoints.test.lua | 5 +-
test/sql/transition.result | 10 +-
test/sql/transitive-transactions.result | 14 +-
test/sql/transitive-transactions.test.lua | 10 +-
test/sql/triggers.result | 19 ++-
test/sql/types.result | 183 ++++++++++++++-------
test/sql/view.result | 25 ++-
38 files changed, 547 insertions(+), 330 deletions(-)
--
2.7.4
next reply other threads:[~2019-07-31 10:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 10:32 imeevma [this message]
2019-07-31 10:32 ` [tarantool-patches] [PATCH v2 1/2] lua: new function luaT_return_error() imeevma
2019-07-31 15:23 ` [tarantool-patches] " Alexander Turenko
2019-07-31 15:39 ` Konstantin Osipov
2019-07-31 15:40 ` Vladislav Shpilevoy
2019-07-31 16:20 ` Imeev Mergen
2019-07-31 17:00 ` Vladislav Shpilevoy
2019-07-31 19:33 ` Konstantin Osipov
2019-08-01 8:35 ` Alexander Turenko
2019-07-31 19:32 ` Konstantin Osipov
2019-07-31 17:15 ` Vladislav Shpilevoy
2019-07-31 22:16 ` Mergen Imeev
2019-08-01 20:03 ` Vladislav Shpilevoy
2019-08-01 8:59 ` Mergen Imeev
2019-07-31 10:32 ` [tarantool-patches] [PATCH v2 2/2] sql: rework error handling in box.execute() imeevma
2019-07-31 22:23 ` [tarantool-patches] " Mergen Imeev
2019-08-02 5:39 ` [tarantool-patches] Re: [PATCH v2 0/2] " Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1564568388.git.imeevma@gmail.com \
--to=imeevma@tarantool.org \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [tarantool-patches] [PATCH v2 0/2] sql: rework error handling in box.execute()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox