From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: tarantool-patches@freelists.org
Subject: [PATCH 0/4] Support savepoints in DDL transactions
Date: Fri, 19 Jul 2019 21:08:38 +0300 [thread overview]
Message-ID: <cover.1563559254.git.vdavydov.dev@gmail.com> (raw)
DDL statements install commit/rollback triggers to complete/revert
changes done to the schema. If a DDL statement is rolled back by a
savepoint, we must remove commit triggers and run rollback triggers,
otherwise we can get an inconsistent schema state. This patch set
addresses this issue.
https://github.com/tarantool/tarantool/issues/4364
https://github.com/tarantool/tarantool/issues/4365
https://github.com/tarantool/tarantool/commits/dv/gh-4364-4365-fix-ddl-savepoint
Vladimir Davydov (4):
Update small library
txn: reverse commit trigger list only before running commit triggers
txn: use savepoints to roll back statements on yield or error
txn: undo commit/rollback triggers when reverting to savepoint
src/box/txn.c | 126 +++++++++++++++++++++++++++++++------
src/box/txn.h | 31 +++++-----
src/lib/core/trigger.h | 11 ----
src/lib/small | 2 +-
test/box/transaction.result | 39 ++++++++++++
test/box/transaction.test.lua | 23 +++++++
test/engine/transaction.result | 4 +-
test/unit/CMakeLists.txt | 2 -
test/unit/rlist.c | 137 -----------------------------------------
test/unit/rlist.result | 88 --------------------------
10 files changed, 188 insertions(+), 275 deletions(-)
delete mode 100644 test/unit/rlist.c
delete mode 100644 test/unit/rlist.result
--
2.11.0
next reply other threads:[~2019-07-19 18:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 18:08 Vladimir Davydov [this message]
2019-07-19 18:08 ` [PATCH 1/4] Update small library Vladimir Davydov
2019-07-24 22:48 ` [tarantool-patches] " Konstantin Osipov
2019-07-25 9:23 ` Vladimir Davydov
2019-07-19 18:08 ` [PATCH 2/4] txn: reverse commit trigger list only before running commit triggers Vladimir Davydov
2019-07-24 22:48 ` [tarantool-patches] " Konstantin Osipov
2019-07-25 9:24 ` Vladimir Davydov
2019-07-25 9:29 ` Konstantin Osipov
2019-07-25 9:35 ` Vladimir Davydov
2019-07-25 14:56 ` Vladimir Davydov
2019-07-26 19:25 ` Konstantin Osipov
2019-07-29 8:45 ` Vladimir Davydov
2019-07-19 18:08 ` [PATCH 3/4] txn: use savepoints to roll back statements on yield or error Vladimir Davydov
2019-07-24 22:55 ` [tarantool-patches] " Konstantin Osipov
2019-07-24 23:19 ` Konstantin Osipov
2019-07-25 9:28 ` Vladimir Davydov
2019-07-25 11:57 ` Vladimir Davydov
2019-07-19 18:08 ` [PATCH 4/4] txn: undo commit/rollback triggers when reverting to savepoint Vladimir Davydov
2019-07-19 19:36 ` [tarantool-patches] " Vladislav Shpilevoy
2019-07-19 19:42 ` Vladimir Davydov
2019-07-26 8:56 ` Vladimir Davydov
2019-07-29 13:11 ` [tarantool-patches] " Konstantin Osipov
2019-07-30 10:54 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1563559254.git.vdavydov.dev@gmail.com \
--to=vdavydov.dev@gmail.com \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH 0/4] Support savepoints in DDL transactions' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox