Tarantool development patches archive
 help / color / mirror / Atom feed
From: imeevma@tarantool.org
To: korablev@tarantool.org
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] [PATCH v2 0/3] sql: do not show IDs generated by trigger
Date: Thu,  4 Jul 2019 14:42:07 +0300	[thread overview]
Message-ID: <cover.1562239051.git.imeevma@gmail.com> (raw)

Currently, if an INSERT was executed by a trigger during the
execution of a statement, if there were any generated identifiers,
they can be displayed as a result of the statement. This is
incorrect, since we are not able to divide the IDs obtained into
those that belong to the table mentioned in the statement and
those that do not belong to this table.

https://github.com/tarantool/tarantool/issues/4188
https://github.com/tarantool/tarantool/tree/imeevma/gh-4188-remove-additonal-generated-ids

Changes in v2:
1) Patch was divided into 3 new patches.

Mergen Imeev (3):
  sql: remove unnecessary AUTOINCREMENT ID generation
  sql: do not show IDs generated by trigger
  sql: remove VDBE from TXN

 src/box/errcode.h                       |  1 +
 src/box/sequence.c                      | 22 +++++++++----
 src/box/sequence.h                      | 13 ++++++--
 src/box/sql/insert.c                    | 15 ++++++---
 src/box/sql/parse.y                     |  4 +--
 src/box/sql/sqlInt.h                    |  2 +-
 src/box/sql/trigger.c                   | 12 +++----
 src/box/sql/vdbe.c                      | 25 ++++++++-------
 src/box/sql/vdbe.h                      |  3 +-
 src/box/sql/vdbeInt.h                   |  2 +-
 src/box/sql/vdbeaux.c                   | 10 +++---
 src/box/txn.h                           | 17 ----------
 test/box/misc.result                    |  1 +
 test/sql/gh-2981-check-autoinc.result   | 32 ++++++++++++++++++
 test/sql/gh-2981-check-autoinc.test.lua | 11 ++++++-
 test/sql/iproto.result                  |  2 --
 test/sql/triggers.result                | 57 +++++++++++++++++++++++++++++++++
 test/sql/triggers.test.lua              | 14 ++++++++
 18 files changed, 177 insertions(+), 66 deletions(-)

-- 
2.7.4

             reply	other threads:[~2019-07-04 11:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-04 11:42 imeevma [this message]
2019-07-04 11:42 ` [tarantool-patches] [PATCH v2 1/3] sql: remove unnecessary AUTOINCREMENT ID generation imeevma
2019-07-08 18:54   ` [tarantool-patches] " n.pettik
2019-07-04 11:42 ` [tarantool-patches] [PATCH v2 2/3] sql: do not show IDs generated by trigger imeevma
2019-07-08 18:54   ` [tarantool-patches] " n.pettik
2019-07-04 11:42 ` [tarantool-patches] [PATCH v2 3/3] sql: remove VDBE from TXN imeevma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1562239051.git.imeevma@gmail.com \
    --to=imeevma@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [tarantool-patches] [PATCH v2 0/3] sql: do not show IDs generated by trigger' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox