From: Serge Petrenko <sergepetrenko@tarantool.org>
To: vdavydov.dev@gmail.com
Cc: tarantool-patches@freelists.org,
Serge Petrenko <sergepetrenko@tarantool.org>
Subject: [PATCH v2 0/2] decimal: expose decimal module to Lua.
Date: Fri, 28 Jun 2019 17:36:37 +0300 [thread overview]
Message-ID: <cover.1561731259.git.sergepetrenko@tarantool.org> (raw)
https://github.com/tarantool/tarantool/issues/692
https://github.com/tarantool/tarantool/tree/sp/gh-692-decimal-lua
This patchset adds decimal module to lua.
Since FFI CDATA is chosen to store decimals on lua stack, a new helper to
register FFI metatypes is added in the first patch.
The second patch does the job itself of exposing the decimal module to lua and
adds a minor test. The patch also contains a documentation request in the commit
message.
Changes in v2:
- various review fixes requested by @vdavydov
- clarify commit message and docbot request.
- remove decimal.add and similar. Only leave
the '+', ... operators for binary operations.
- add more tests.
- minor code cleanup.
Serge Petrenko (2):
lua/utils: add a function to register FFI metatypes.
decimal: expose decimal type to lua.
src/CMakeLists.txt | 1 +
src/lua/decimal.c | 351 ++++++++++++++++++++++++++++++++++
src/lua/decimal.h | 47 +++++
src/lua/init.c | 2 +
src/lua/utils.c | 28 +++
src/lua/utils.h | 13 ++
test/app/decimal.result | 382 ++++++++++++++++++++++++++++++++++++++
test/app/decimal.test.lua | 110 +++++++++++
8 files changed, 934 insertions(+)
create mode 100644 src/lua/decimal.c
create mode 100644 src/lua/decimal.h
create mode 100644 test/app/decimal.result
create mode 100644 test/app/decimal.test.lua
--
2.20.1 (Apple Git-117)
next reply other threads:[~2019-06-28 14:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 14:36 Serge Petrenko [this message]
2019-06-28 14:36 ` [PATCH v2 1/2] lua/utils: add a function to register FFI metatypes Serge Petrenko
2019-06-28 14:36 ` [PATCH v2 2/2] decimal: expose decimal type to lua Serge Petrenko
2019-06-28 15:32 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1561731259.git.sergepetrenko@tarantool.org \
--to=sergepetrenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [PATCH v2 0/2] decimal: expose decimal module to Lua.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox