From: imeevma@tarantool.org To: korablev@tarantool.org Cc: tarantool-patches@freelists.org Subject: [tarantool-patches] [PATCH v1 0/2] sql: clean-up in case constraint creation failed Date: Tue, 25 Jun 2019 18:31:51 +0300 [thread overview] Message-ID: <cover.1561476468.git.imeevma@gmail.com> (raw) This patch makes VDBE run destructors before halting in case constraint creation failed. This is done using new opcode OP_Error, which allows to set an error and do a jump without halting VDBE. https://github.com/tarantool/tarantool/issues/4183 https://github.com/tarantool/tarantool/tree/imeevma/gh-4183-clean-up-when-constraint-creation-failed Mergen Imeev (2): sql: add OP_Error opcode in VDBE sql: clean-up in case constraint creation failed src/box/sql/build.c | 94 +++++++++++++++++++++++++++++------------------- src/box/sql/sqlInt.h | 3 ++ src/box/sql/vdbe.c | 12 +++++++ test/sql/checks.result | 3 +- test/sql/checks.test.lua | 2 +- test/sql/clear.result | 27 ++++++++++++++ test/sql/clear.test.lua | 11 ++++++ 7 files changed, 113 insertions(+), 39 deletions(-) -- 2.7.4
next reply other threads:[~2019-06-25 15:31 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-25 15:31 imeevma [this message] 2019-06-25 15:31 ` [tarantool-patches] [PATCH v1 1/2] sql: add OP_Error opcode in VDBE imeevma 2019-06-26 16:11 ` [tarantool-patches] " n.pettik 2019-06-25 15:31 ` [tarantool-patches] [PATCH v1 2/2] sql: clean-up in case constraint creation failed imeevma 2019-06-26 16:11 ` [tarantool-patches] " n.pettik
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1561476468.git.imeevma@gmail.com \ --to=imeevma@tarantool.org \ --cc=korablev@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [tarantool-patches] [PATCH v1 0/2] sql: clean-up in case constraint creation failed' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox