From: Roman Khabibov <roman.habibov@tarantool.org>
To: tarantool-patches@freelists.org
Cc: alexander.turenko@tarantool.org
Subject: [tarantool-patches] [PATCH v2 0/2] take getaddrinfo() errors into account
Date: Tue, 25 Jun 2019 16:38:26 +0300 [thread overview]
Message-ID: <cover.1561469272.git.roman.habibov@tarantool.org> (raw)
Before this patch, branch when getaddrinfo() returns error codes
couldn't be reached on Mac OS, because they are greater than 0 on
Mac OS (checking for errors was rc < 0).
Roman Khabibov (2):
lua: return getaddrinfo() errors
say: take getaddrinfo() errors into account
src/box/lua/net_box.lua | 7 +++++--
src/lib/core/coio_task.c | 2 +-
src/lib/core/say.c | 3 ++-
src/lua/socket.c | 17 ++++++++++++++++-
src/lua/socket.lua | 37 +++++++++++++++++++++++--------------
test/app/socket.result | 21 ++++++++++++++++++++-
test/app/socket.test.lua | 10 ++++++++++
test/box-tap/cfg.test.lua | 19 ++++++++++++++++++-
test/box/net.box.result | 11 +++++++++++
test/box/net.box.test.lua | 8 ++++++++
test/unit/coio.cc | 7 ++++++-
test/unit/coio.result | 4 +++-
12 files changed, 123 insertions(+), 23 deletions(-)
--
Branch: https://github.com/tarantool/tarantool/tree/romanhabibov/gh-4138-getaddrinfo
Issue: https://github.com/tarantool/tarantool/issues/4138
2.20.1 (Apple Git-117)
next reply other threads:[~2019-06-25 13:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 13:38 Roman Khabibov [this message]
2019-06-25 13:38 ` [tarantool-patches] [PATCH v2 2/2] say: " Roman Khabibov
2019-07-23 14:52 ` [tarantool-patches] " Alexander Turenko
2019-08-05 13:32 ` Roman Khabibov
2019-08-28 21:34 ` Alexander Turenko
2019-08-29 0:51 ` Alexander Turenko
[not found] ` <8E98F721-601F-436D-8F0A-5E399D8F7CAB@tarantool.org>
2019-09-06 13:44 ` Alexander Turenko
2019-09-10 12:52 ` Roman Khabibov
2019-11-01 15:19 ` [Tarantool-patches] " Alexander Turenko
2019-11-21 17:28 ` [Tarantool-patches] [tarantool-patches] " Roman Khabibov
2019-12-08 19:48 ` Alexander Turenko
2019-12-10 16:25 ` Roman Khabibov
2019-12-18 15:01 ` Alexander Turenko
2019-12-21 17:50 ` Roman Khabibov
2019-12-23 12:56 ` Alexander Turenko
2019-12-23 13:38 ` Alexander Turenko
2019-12-26 17:29 ` Roman Khabibov
2019-12-26 21:05 ` Alexander Turenko
2019-12-27 13:01 ` Roman Khabibov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1561469272.git.roman.habibov@tarantool.org \
--to=roman.habibov@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH v2 0/2] take getaddrinfo() errors into account' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox