Tarantool development patches archive
 help / color / mirror / Atom feed
From: Serge Petrenko <sergepetrenko@tarantool.org>
To: vdavydov.dev@gmail.com
Cc: tarantool-patches@freelists.org,
	Serge Petrenko <sergepetrenko@tarantool.org>
Subject: [PATCH 0/2] memtx: make space format check yield occasionally
Date: Mon,  3 Jun 2019 18:51:04 +0300	[thread overview]
Message-ID: <cover.1559576874.git.sergepetrenko@tarantool.org> (raw)

https://github.com/tarantool/tarantool/issues/3976
https://github.com/tarantool/tarantool/tree/sp/background-space-format

After we've made memtx index build non-blocking, it seems reasonable to do the
same thing for format checks.

The first patch adds yields to memtx_space_check_format, and an on_replace
trigger to enforce new format for concurrently inserted tuples.

The second patch moves an appropriate test case from vinyl suite to engine
suite and adds a handy error injection for the matter.

Serge Petrenko (2):
  memtx: add yields during space format check
  test: move vinyl space format test case to engine suite

 src/box/memtx_space.c           | 125 +++++++++++++++++++++++++-------
 src/box/vinyl.c                 |   6 ++
 src/lib/core/errinj.h           |   1 +
 test/box/errinj.result          |  36 ++++-----
 test/engine/errinj_ddl.result   |  68 +++++++++++++++++
 test/engine/errinj_ddl.test.lua |  33 +++++++++
 test/vinyl/errinj_ddl.result    |  75 -------------------
 test/vinyl/errinj_ddl.test.lua  |  35 ---------
 8 files changed, 226 insertions(+), 153 deletions(-)

-- 
2.20.1 (Apple Git-117)

             reply	other threads:[~2019-06-03 15:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-03 15:51 Serge Petrenko [this message]
2019-06-03 15:51 ` [PATCH 1/2] memtx: add yields during space format check Serge Petrenko
2019-06-03 15:54   ` [tarantool-patches] " Serge Petrenko
2019-06-04 15:17   ` Vladimir Davydov
2019-06-03 15:51 ` [PATCH 2/2] test: move vinyl space format test case to engine suite Serge Petrenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1559576874.git.sergepetrenko@tarantool.org \
    --to=sergepetrenko@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [PATCH 0/2] memtx: make space format check yield occasionally' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox