Tarantool development patches archive
 help / color / mirror / Atom feed
From: Serge Petrenko <sergepetrenko@tarantool.org>
To: vdavydov.dev@gmail.com
Cc: tarantool-patches@freelists.org,
	Serge Petrenko <sergepetrenko@tarantool.org>
Subject: [PATCH v4 0/2] memtx: add yields during index build
Date: Thu, 30 May 2019 15:13:26 +0300	[thread overview]
Message-ID: <cover.1559218070.git.sergepetrenko@tarantool.org> (raw)

This patchset makes memtx engine yield during index build, which prevents it
from stalling the event loop, and moves appropriate test cases from vinyl suite,
where such a feature was implemented earlier, to engine suite.

The first patch introduces changes in index build mechanism
The second patch adds necessary tests

Changes in v4:
  - move errinj introduction to the
    second patch
  - move more tests from vinyl/errinj_ddl
    to engine/errinj_ddl
  - unify errinjs in memtx and vinyl index
    build for easier testing
  - ref count cursor before yield in index
    build

Changes in v3:
 - split the patch into two,
   the second one moving appropriate
   tests from vinyl to engine suite
 - add a docbot request to the
   first patch
 - ensure index unique constraints
   are checked in on_replace triggers
 - fix tuple comparsion in on_replace
   triggers

Changes in v2:
 - add an on_replace trigger
   to handle concurrent replaces
   while index build yields
 - modify test case slightly,
   test concurrent replaces.

Serge Petrenko (2):
  memtx: add yields during index build
  test: move background index build test to engine suite from vinyl

 src/box/memtx_space.c           | 107 ++++++++++++
 src/box/vinyl.c                 |  16 ++
 src/lib/core/errinj.h           |   1 +
 test/box/errinj.result          |   2 +
 test/engine/ddl.result          | 111 +++++++++++++
 test/engine/ddl.test.lua        |  72 ++++++++
 test/engine/errinj_ddl.result   | 284 ++++++++++++++++++++++++++++++++
 test/engine/errinj_ddl.test.lua | 133 +++++++++++++++
 test/engine/suite.ini           |   2 +-
 test/vinyl/ddl.result           | 118 -------------
 test/vinyl/ddl.test.lua         |  70 --------
 test/vinyl/errinj_ddl.result    | 182 --------------------
 test/vinyl/errinj_ddl.test.lua  |  81 ---------
 13 files changed, 727 insertions(+), 452 deletions(-)
 create mode 100644 test/engine/errinj_ddl.result
 create mode 100644 test/engine/errinj_ddl.test.lua

-- 
2.20.1 (Apple Git-117)

             reply	other threads:[~2019-05-30 12:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-30 12:13 Serge Petrenko [this message]
2019-05-30 12:13 ` [PATCH v4 1/2] " Serge Petrenko
2019-05-30 12:13 ` [PATCH v4 2/2] test: move background index build test to engine suite from vinyl Serge Petrenko
2019-05-30 13:38 ` [PATCH v4 0/2] memtx: add yields during index build Vladimir Davydov
2019-05-30 13:41   ` [tarantool-patches] " Serge Petrenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1559218070.git.sergepetrenko@tarantool.org \
    --to=sergepetrenko@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [PATCH v4 0/2] memtx: add yields during index build' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox