From: Serge Petrenko <sergepetrenko@tarantool.org>
To: vdavydov.dev@gmail.com
Cc: tarantool-patches@freelists.org, kostja@tarantool.org,
Serge Petrenko <sergepetrenko@tarantool.org>
Subject: [PATCH v3 0/2] memtx: add yields during index build
Date: Tue, 28 May 2019 18:33:23 +0300 [thread overview]
Message-ID: <cover.1559056498.git.sergepetrenko@tarantool.org> (raw)
https://github.com/tarantool/tarantool/issues/3976
https://github.com/tarantool/tarantool/tree/sp/gh-3976-background-index-build
This patchset makes memtx engine yield during index build, which prevents it
from stalling the event loop, and moves appropriate test cases from vinyl suite,
where such a feature was implemented earlier, to engine suite.
The first patch introduces changes in index build mechanism
The second patch adds necessary tests
Changes in v3:
- split the patch into two,
the second one moving appropriate
tests from vinyl to engine suite
- add a docbot request to the
first patch
- ensure index unique constraints
are checked in on_replace triggers
- fix tuple comparsion in on_replace
triggers
Changes in v2:
- add an on_replace trigger
to handle concurrent replaces
while index build yields
- modify test case slightly,
test concurrent replaces.
Serge Petrenko (2):
memtx: add yields during index build
test: move background index build test to engine suite from vinyl
src/box/memtx_space.c | 102 +++++++++++++++++++
src/box/vinyl.c | 8 ++
src/lib/core/errinj.h | 1 +
test/box/errinj.result | 2 +
test/engine/ddl.result | 215 +++++++++++++++++++++++++++++++++++++++
test/engine/ddl.test.lua | 121 ++++++++++++++++++++++
test/vinyl/ddl.result | 118 ---------------------
test/vinyl/ddl.test.lua | 70 -------------
8 files changed, 449 insertions(+), 188 deletions(-)
--
2.20.1 (Apple Git-117)
next reply other threads:[~2019-05-28 15:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 15:33 Serge Petrenko [this message]
2019-05-28 15:33 ` [PATCH v3 1/2] " Serge Petrenko
2019-05-29 15:58 ` Vladimir Davydov
2019-05-28 15:33 ` [PATCH v3 2/2] test: move background index build test to engine suite from vinyl Serge Petrenko
2019-05-28 15:39 ` [tarantool-patches] " Serge Petrenko
2019-05-29 16:03 ` Vladimir Davydov
2019-05-29 11:01 ` [PATCH v3 0/2] memtx: add yields during index build Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1559056498.git.sergepetrenko@tarantool.org \
--to=sergepetrenko@tarantool.org \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [PATCH v3 0/2] memtx: add yields during index build' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox