From: imeevma@tarantool.org
To: korablev@tarantool.org
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] [PATCH v1 0/3] sql: make SQL_TARANTOOL_ERROR the only errcode of OP_Halt
Date: Fri, 12 Apr 2019 15:34:15 +0300 [thread overview]
Message-ID: <cover.1555072183.git.imeevma@gmail.com> (raw)
Currently there are two ways to set an error in SQL - through
OP_Halt and through abort_due_to_error. After this patch, all
errors set via OP_Halt will be set using diag_set().
https://github.com/tarantool/tarantool/issues/4074
https://github.com/tarantool/tarantool/tree/imeevma/gh-4074-diag_set-in-op_halt
Mergen Imeev (3):
sql: remove mayAbort field from struct Parse
sql: rework diag_set() in OP_Halt
sql: make SQL_TARANTOOL_ERROR the only errcode of OP_Halt
src/box/sql/build.c | 57 +-----------------
src/box/sql/expr.c | 9 ++-
src/box/sql/fk_constraint.c | 42 +------------
src/box/sql/insert.c | 31 +++++-----
src/box/sql/select.c | 17 +++---
src/box/sql/sqlInt.h | 3 -
src/box/sql/trigger.c | 12 ++--
src/box/sql/vdbe.c | 24 ++------
src/box/sql/vdbe.h | 3 -
src/box/sql/vdbeaux.c | 127 ----------------------------------------
test/sql-tap/e_select1.test.lua | 4 +-
test/sql-tap/limit.test.lua | 26 ++++----
test/sql-tap/select4.test.lua | 4 +-
test/sql/iproto.result | 18 ++++--
14 files changed, 68 insertions(+), 309 deletions(-)
--
2.7.4
next reply other threads:[~2019-04-12 12:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 12:34 imeevma [this message]
2019-04-12 12:34 ` [tarantool-patches] [PATCH v1 1/3] sql: remove mayAbort field from struct Parse imeevma
2019-04-15 14:06 ` [tarantool-patches] " n.pettik
2019-04-22 7:49 ` Imeev Mergen
2019-04-26 7:25 ` Mergen Imeev
2019-04-28 23:35 ` n.pettik
2019-04-12 12:34 ` [tarantool-patches] [PATCH v1 2/3] sql: rework diag_set() in OP_Halt imeevma
2019-04-15 15:21 ` [tarantool-patches] " n.pettik
2019-04-22 8:24 ` Imeev Mergen
2019-04-24 12:19 ` n.pettik
2019-04-26 7:48 ` Mergen Imeev
2019-04-28 23:35 ` n.pettik
2019-04-29 15:05 ` Imeev Mergen
2019-05-05 11:31 ` Imeev Mergen
2019-04-12 12:34 ` [tarantool-patches] [PATCH v1 3/3] sql: make SQL_TARANTOOL_ERROR the only errcode of OP_Halt imeevma
2019-04-15 15:19 ` [tarantool-patches] " n.pettik
2019-04-22 8:47 ` Imeev Mergen
2019-04-22 9:53 ` Imeev Mergen
2019-04-26 7:37 ` Mergen Imeev
2019-04-28 23:35 ` n.pettik
2019-05-05 12:16 ` Imeev Mergen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1555072183.git.imeevma@gmail.com \
--to=imeevma@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH v1 0/3] sql: make SQL_TARANTOOL_ERROR the only errcode of OP_Halt' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox