Tarantool development patches archive
 help / color / mirror / Atom feed
From: imeevma@tarantool.org
To: vdavydov.dev@gmail.com
Cc: tarantool-patches@freelists.org
Subject: [PATCH v2 0/3] box: drop _sql_stat1 and _sql_stat4 tables.
Date: Wed,  3 Apr 2019 19:58:29 +0300	[thread overview]
Message-ID: <cover.1554310018.git.imeevma@gmail.com> (raw)

System tables _sql_stat1 and _sql_stat4 become unused and should
be dropped.

This patch breaks backward compatibility!

https://github.com/tarantool/tarantool/issues/2843
https://github.com/tarantool/tarantool/tree/imeevma/gh-2843-drop-_sql_stat-tables

v1:
https://www.freelists.org/post/tarantool-patches/PATCH-v1-11-sql-remove-sql-stat1-and-sql-stat4-system-tables

Changes in new version:
1) Original patch divided into three.
2) A bit changed commit message and comments.

Mergen Imeev (3):
  sql: allocate memory for index_id in VDBE
  sql: remove space_by_id() from analyze.c
  box: remove _sql_stat1 and _sql_stat4 system tables

 src/box/bootstrap.snap                  | Bin 4477 -> 4374 bytes
 src/box/lua/space.cc                    |   4 ----
 src/box/lua/upgrade.lua                 |  27 ------------------------
 src/box/schema.cc                       |  16 --------------
 src/box/schema_def.h                    |   3 ---
 src/box/sql.c                           |   8 +------
 src/box/sql.h                           |   5 +++++
 src/box/sql/analyze.c                   |  17 +++++++++------
 src/box/sql/build.c                     |  36 +++++++-------------------------
 test/app-tap/tarantoolctl.test.lua      |   4 ++--
 test/box-py/bootstrap.result            |   8 -------
 test/box/access_misc.result             |   5 -----
 test/box/access_sysview.result          |   6 +++---
 test/box/alter.result                   |   3 ---
 test/sql-tap/gh-3350-skip-scan.test.lua |  10 ++++-----
 test/sql-tap/suite.ini                  |   1 +
 test/sql/delete.result                  |   4 ++--
 test/sql/delete.test.lua                |   2 +-
 test/sql/triggers.result                |   4 ++--
 test/sql/triggers.test.lua              |   4 ++--
 test/sql/upgrade.result                 |  20 ------------------
 test/sql/upgrade.test.lua               |   4 ----
 test/wal_off/alter.result               |   2 +-
 23 files changed, 44 insertions(+), 149 deletions(-)

-- 
2.7.4

             reply	other threads:[~2019-04-03 16:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-03 16:58 imeevma [this message]
2019-04-03 16:58 ` [PATCH v2 1/3] sql: allocate memory for index_id in VDBE imeevma
2019-04-04 16:00   ` Vladimir Davydov
2019-04-03 16:58 ` [PATCH v2 2/3] sql: remove space_by_id() from analyze.c imeevma
2019-04-04 16:03   ` Vladimir Davydov
2019-04-04 17:41     ` Vladimir Davydov
2019-04-03 16:58 ` [PATCH v2 3/3] box: remove _sql_stat1 and _sql_stat4 system tables imeevma
2019-04-03 17:19   ` Vladimir Davydov
2019-04-03 17:38     ` Re[2]: " Мерген Имеев
2019-04-03 17:58       ` Vladimir Davydov
2019-04-03 18:04         ` [tarantool-patches] Re: [tarantool-patches] " Мерген Имеев
2019-04-04 16:11   ` Vladimir Davydov
2019-04-04 18:18     ` Mergen Imeev
2019-04-05 11:36 ` [tarantool-patches] [PATCH v2 0/3] box: drop _sql_stat1 and _sql_stat4 tables Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1554310018.git.imeevma@gmail.com \
    --to=imeevma@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [PATCH v2 0/3] box: drop _sql_stat1 and _sql_stat4 tables.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox