Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: Alexander Turenko <alexander.turenko@tarantool.org>,
	tarantool-patches@freelists.org
Subject: [PATCH 0/2] Fix tarantoolctl cat/play premature stop
Date: Wed, 20 Mar 2019 21:41:12 +0300	[thread overview]
Message-ID: <cover.1553104456.git.alexander.turenko@tarantool.org> (raw)

https://github.com/tarantool/tarantool/issues/3827
https://github.com/tarantool/tarantool/tree/Totktonada/gh-3827-fix-tarantoolctl-cat-premature-stop

tarantoolctl cat/play now don't miss records which match a user-provided
arguments. It was possible when records from several masters (with
different replica_id parameters) reside in a file and --to argument is
provided. A first record with LSN equal or above a 'to' value did cause
stop the file processing, but it is possible that there are records with
lesser LSN from another masters. Now we stop only when one explicit
--replica argument is provided.

The patchset is splitted into two patches: refactoring w/o behaviour
changes (+test) and the patch that fixes the behaviour.

Alexander Turenko (2):
  Unify tarantoolctl cat/play xlog filtering code
  Fix tarantoolctl cat/play premature stop with --to

 extra/dist/tarantoolctl.in         | 124 +++++++++++++--------
 test/app-tap/tarantoolctl.test.lua | 172 ++++++++++++++++++++++++++++-
 2 files changed, 244 insertions(+), 52 deletions(-)

-- 
2.20.1

             reply	other threads:[~2019-03-20 18:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20 18:41 Alexander Turenko [this message]
2019-03-20 18:41 ` [PATCH 1/2] Unify tarantoolctl cat/play xlog filtering code Alexander Turenko
2019-03-20 18:41 ` [PATCH 2/2] Fix tarantoolctl cat/play premature stop with --to Alexander Turenko
2019-03-26 18:11 ` [PATCH 0/2] Fix tarantoolctl cat/play premature stop Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1553104456.git.alexander.turenko@tarantool.org \
    --to=alexander.turenko@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [PATCH 0/2] Fix tarantoolctl cat/play premature stop' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox