From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH 0/2] Fix tarantoolctl cat/play premature stop
Date: Tue, 26 Mar 2019 21:11:41 +0300 [thread overview]
Message-ID: <20190326181141.ocuk6opndh6yw2kx@esperanza> (raw)
In-Reply-To: <cover.1553104456.git.alexander.turenko@tarantool.org>
On Wed, Mar 20, 2019 at 09:41:12PM +0300, Alexander Turenko wrote:
> https://github.com/tarantool/tarantool/issues/3827
> https://github.com/tarantool/tarantool/tree/Totktonada/gh-3827-fix-tarantoolctl-cat-premature-stop
>
> tarantoolctl cat/play now don't miss records which match a user-provided
> arguments. It was possible when records from several masters (with
> different replica_id parameters) reside in a file and --to argument is
> provided. A first record with LSN equal or above a 'to' value did cause
> stop the file processing, but it is possible that there are records with
> lesser LSN from another masters. Now we stop only when one explicit
> --replica argument is provided.
>
> The patchset is splitted into two patches: refactoring w/o behaviour
> changes (+test) and the patch that fixes the behaviour.
>
> Alexander Turenko (2):
> Unify tarantoolctl cat/play xlog filtering code
> Fix tarantoolctl cat/play premature stop with --to
Awesome! Pushed to master and 2.1, thanks!
prev parent reply other threads:[~2019-03-26 18:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 18:41 Alexander Turenko
2019-03-20 18:41 ` [PATCH 1/2] Unify tarantoolctl cat/play xlog filtering code Alexander Turenko
2019-03-20 18:41 ` [PATCH 2/2] Fix tarantoolctl cat/play premature stop with --to Alexander Turenko
2019-03-26 18:11 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190326181141.ocuk6opndh6yw2kx@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH 0/2] Fix tarantoolctl cat/play premature stop' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox