From: Nikita Pettik <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org, Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] [PATCH 0/2] Fix wrong field count in bytecode for ANALYZE
Date: Tue, 19 Mar 2019 02:51:19 +0300 [thread overview]
Message-ID: <cover.1552943281.git.korablev@tarantool.org> (raw)
Branch: https://github.com/tarantool/tarantool/tree/np/fix-analyze-makerecord
First patch fixes obvious bug in VDBE bytecode for ANALYZE SQL
statement. To prevent similar bugs in the future, second patch
explicitly sets field count for _sql_stat1 and _sql_stat4 system
spaces.
Nikita Pettik (2):
sql: fix OP_MakeRecord argument of ANALYZE bytecode
schema: add exact field count to SQL stat spaces
src/box/bootstrap.snap | Bin 1831 -> 1840 bytes
src/box/lua/upgrade.lua | 29 ++++++++++++++-
src/box/sql/analyze.c | 2 +-
test/box-py/bootstrap.result | 6 ++--
test/box/access_misc.result | 4 +--
...{sql-statN-index-drop.result => analyze.result} | 17 +++++++++
...-statN-index-drop.test.lua => analyze.test.lua} | 6 ++++
test/sql/upgrade.result | 39 +++++++++++++++++++--
test/sql/upgrade.test.lua | 13 +++++++
9 files changed, 107 insertions(+), 9 deletions(-)
rename test/sql/{sql-statN-index-drop.result => analyze.result} (86%)
rename test/sql/{sql-statN-index-drop.test.lua => analyze.test.lua} (91%)
--
2.15.1
next reply other threads:[~2019-03-18 23:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 23:51 Nikita Pettik [this message]
2019-03-18 23:51 ` [tarantool-patches] [PATCH 1/2] sql: fix OP_MakeRecord argument of ANALYZE bytecode Nikita Pettik
2019-03-18 23:51 ` [tarantool-patches] [PATCH 2/2] schema: add exact field count to SQL stat spaces Nikita Pettik
2019-03-21 13:31 ` [tarantool-patches] " Vladislav Shpilevoy
2019-03-21 15:22 ` n.pettik
2019-03-21 15:39 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1552943281.git.korablev@tarantool.org \
--to=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [tarantool-patches] [PATCH 0/2] Fix wrong field count in bytecode for ANALYZE' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox