Tarantool development patches archive
 help / color / mirror / Atom feed
From: Nikita Pettik <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org, Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] [PATCH 0/2] SQL types fixes
Date: Mon, 11 Mar 2019 21:10:24 +0300	[thread overview]
Message-ID: <cover.1552327461.git.korablev@tarantool.org> (raw)

Branch: https://github.com/tarantool/tarantool/tree/np/sql-types-fixes
No related issue

First patch fixes names send as column meta-information. After
BLOB type was substituted with SCALAR, it can be confusing saying
that column has type BLOB. Moreover, other string represantations
have been replaced with exact names of NoSQL types (i.e. STRING,
NUMER etc).

Second patch fixes wrong type calculation for returning value for
function: it takes place during name resolution, and its second
promotion during byte-code generation is redundant (and in some
cases is wrong).

Nikita Pettik (2):
  sql: make type in column-meta be consistent with NoSQL names
  sql: don't change type of function's retval after codegen

 src/box/sql/expr.c                           |  11 ---
 src/box/sql/select.c                         |  31 +-------
 test/sql/errinj.result                       |   2 +-
 test/sql/gh-2362-select-access-rights.result |   4 +-
 test/sql/iproto.result                       | 109 ++++++++++++++++++---------
 test/sql/iproto.test.lua                     |  15 ++++
 6 files changed, 97 insertions(+), 75 deletions(-)

-- 
2.15.1

             reply	other threads:[~2019-03-11 18:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-11 18:10 Nikita Pettik [this message]
2019-03-11 18:10 ` [tarantool-patches] [PATCH 1/2] sql: make type in column-meta be consistent with NoSQL names Nikita Pettik
2019-03-21  9:03   ` [tarantool-patches] " Vladislav Shpilevoy
2019-03-21 14:00   ` Konstantin Osipov
2019-03-11 18:10 ` [tarantool-patches] [PATCH 2/2] sql: don't change type of function's retval after codegen Nikita Pettik
2019-03-21  9:03   ` [tarantool-patches] " Vladislav Shpilevoy
2019-03-21 12:51     ` n.pettik
2019-03-21 14:46       ` Vladislav Shpilevoy
2019-04-03  7:58 ` [tarantool-patches] Re: [PATCH 0/2] SQL types fixes Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1552327461.git.korablev@tarantool.org \
    --to=korablev@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [tarantool-patches] [PATCH 0/2] SQL types fixes' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox