From: Nikita Pettik <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org, Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] [PATCH 0/4] Fix integer overflow behaviour during VDBE execution
Date: Wed, 20 Feb 2019 14:57:36 +0300 [thread overview]
Message-ID: <cover.1550663540.git.korablev@tarantool.org> (raw)
Branch: https://github.com/tarantool/tarantool/tree/np/gh-3735-integer-overflow
Issue: https://github.com/tarantool/tarantool/issues/3735
Current patch-set fixes integer overflow behaviour during VDBE
execution. Originally, SQLite acts quite misleading in such
situations: intead of raising error, it simply treats overflowed
integers as floating point numbers. Lets fix it everywhere it is
possible (math and CAST operators, validate decoded msgpack).
Nikita Pettik (4):
sql: raise an error if int is overflowed during math operations
sql: raise an integer overflow error during CAST
sql: refactor sqlVdbeMsgpackGet()
sql: raise integer overflow error during msgpack decode
src/box/sql/vdbe.c | 21 ++++--
src/box/sql/vdbeInt.h | 13 +++-
src/box/sql/vdbeaux.c | 132 ++++++++++++++++++-------------------
src/box/sql/vdbemem.c | 8 ++-
test/sql/integer-overflow.result | 76 +++++++++++++++++++++
test/sql/integer-overflow.test.lua | 34 ++++++++++
6 files changed, 205 insertions(+), 79 deletions(-)
create mode 100644 test/sql/integer-overflow.result
create mode 100644 test/sql/integer-overflow.test.lua
--
2.15.1
next reply other threads:[~2019-02-20 11:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 11:57 Nikita Pettik [this message]
2019-02-20 11:57 ` [tarantool-patches] [PATCH 1/4] sql: raise an error if int is overflowed during math operations Nikita Pettik
2019-02-20 11:57 ` [tarantool-patches] [PATCH 2/4] sql: raise an integer overflow error during CAST Nikita Pettik
2019-02-20 11:57 ` [tarantool-patches] [PATCH 3/4] sql: refactor sqlVdbeMsgpackGet() Nikita Pettik
2019-02-20 11:57 ` [tarantool-patches] [PATCH 4/4] sql: raise integer overflow error during msgpack decode Nikita Pettik
2019-02-20 18:25 ` [tarantool-patches] " Konstantin Osipov
2019-02-20 18:39 ` n.pettik
2019-02-20 18:46 ` Konstantin Osipov
2019-02-22 18:30 ` [tarantool-patches] Re: [PATCH 0/4] Fix integer overflow behaviour during VDBE execution Vladislav Shpilevoy
2019-02-25 11:58 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1550663540.git.korablev@tarantool.org \
--to=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [tarantool-patches] [PATCH 0/4] Fix integer overflow behaviour during VDBE execution' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox