Tarantool development patches archive
 help / color / mirror / Atom feed
From: Nikita Pettik <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org, Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] [PATCH 0/3] Concatenation operator type fixes
Date: Tue, 19 Feb 2019 11:28:20 +0300	[thread overview]
Message-ID: <cover.1550532805.git.korablev@tarantool.org> (raw)

This patch makes concatenation operator follow ANSI rules.
For now, only operands of string-like types (TEXT or BLOB) are
accepted. What is more, fixed resulting type of concatenation:
if both operands are of BLOB type, then the resulting value is of
BLOB value too.

Branch: https://github.com/tarantool/tarantool/tree/np/gh-3544-fix-randomblob-type
Issue: https://github.com/tarantool/tarantool/issues/3544

Nikita Pettik (3):
  sql: fix value of mask to map VDBE memory type
  sql: allow only string-like arguments for concatenation
  sql: fix resulting type for concatenation operator

 src/box/errcode.h               |  1 +
 src/box/sql/vdbe.c              | 59 ++++++++++++++++++++++++++++++++++++++---
 src/box/sql/vdbeInt.h           |  9 +++++++
 src/box/sql/vdbeapi.c           |  2 +-
 test/box/misc.result            |  1 +
 test/sql-tap/autoinc.test.lua   | 12 ++++-----
 test/sql-tap/e_select1.test.lua |  4 +--
 test/sql-tap/func.test.lua      |  4 +--
 test/sql-tap/sort.test.lua      |  6 ++---
 test/sql-tap/tkt2192.test.lua   |  4 +--
 test/sql-tap/trigger5.test.lua  |  4 +--
 test/sql/types.result           | 42 +++++++++++++++++++++++++++++
 test/sql/types.test.lua         | 16 +++++++++++
 13 files changed, 143 insertions(+), 21 deletions(-)

-- 
2.15.1

             reply	other threads:[~2019-02-19  8:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-19  8:28 Nikita Pettik [this message]
2019-02-19  8:28 ` [tarantool-patches] [PATCH 1/3] sql: fix value of mask to map VDBE memory type Nikita Pettik
2019-02-19  8:28 ` [tarantool-patches] [PATCH 2/3] sql: allow only string-like arguments for concatenation Nikita Pettik
2019-02-19  8:28 ` [tarantool-patches] [PATCH 3/3] sql: fix resulting type for concatenation operator Nikita Pettik
2019-02-22 15:54 ` [tarantool-patches] Re: [PATCH 0/3] Concatenation operator type fixes Vladislav Shpilevoy
2019-02-25 11:42 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1550532805.git.korablev@tarantool.org \
    --to=korablev@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [tarantool-patches] [PATCH 0/3] Concatenation operator type fixes' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox