From: imeevma@tarantool.org
To: korablev@tarantool.org
Cc: tarantool-patches@freelists.org, kostja@tarantool.org
Subject: [tarantool-patches] [PATCH v2 0/2] sql: use diag_set() for errors in SQL
Date: Fri, 15 Feb 2019 20:14:48 +0300 [thread overview]
Message-ID: <cover.1550250721.git.imeevma@gmail.com> (raw)
The goal of this patch-set is to rework all SQL errors and make
Tarantool ones from them.
Difference from v1: Added patch that removes field suppressErr.
https://github.com/tarantool/tarantool/issues/3965
https://github.com/tarantool/tarantool/tree/imeevma/gh-3965-use-diag_set-to-describe-error
Previous versions:
https://www.freelists.org/post/tarantool-patches/PATCH-v1-11-sql-rework-no-such-object-and-object-exists-errors
Mergen Imeev (2):
sql: remove field suppressErr from struct sql
sql: rework "no such object" and "object exists" errors
src/box/errcode.h | 7 +--
src/box/lua/schema.lua | 4 +-
src/box/space.h | 2 +-
src/box/sql/build.c | 37 +++++++-------
src/box/sql/delete.c | 3 +-
src/box/sql/expr.c | 5 +-
src/box/sql/pragma.c | 3 +-
src/box/sql/resolve.c | 25 ++++-----
src/box/sql/select.c | 12 +++--
src/box/sql/sqlInt.h | 9 +++-
src/box/sql/update.c | 5 +-
src/box/sql/util.c | 19 ++++---
test/box/misc.result | 5 +-
test/sql-tap/alter.test.lua | 2 +-
test/sql-tap/analyzeF.test.lua | 4 +-
test/sql-tap/check.test.lua | 4 +-
test/sql-tap/e_select1.test.lua | 26 ++++------
test/sql-tap/fkey2.test.lua | 2 +-
test/sql-tap/func.test.lua | 2 +-
test/sql-tap/gh-2367-pragma.test.lua | 2 +-
test/sql-tap/gh-2996-indexed-by.test.lua | 12 ++---
test/sql-tap/gh2130-index-refer-table.test.lua | 4 +-
test/sql-tap/identifier_case.test.lua | 2 +-
test/sql-tap/in1.test.lua | 2 +-
test/sql-tap/in3.test.lua | 2 +-
test/sql-tap/index-info.test.lua | 2 +-
test/sql-tap/index1.test.lua | 6 +--
test/sql-tap/insert1.test.lua | 6 +--
test/sql-tap/insert3.test.lua | 4 +-
test/sql-tap/join.test.lua | 2 +-
test/sql-tap/limit.test.lua | 4 +-
test/sql-tap/lua-tables.test.lua | 2 +-
test/sql-tap/lua_sql.test.lua | 2 +-
test/sql-tap/misc1.test.lua | 4 +-
test/sql-tap/select1.test.lua | 16 +++---
test/sql-tap/select4.test.lua | 10 ++--
test/sql-tap/select5.test.lua | 8 +--
test/sql-tap/selectB.test.lua | 52 ++++++-------------
test/sql-tap/table.test.lua | 16 +++---
test/sql-tap/tkt-4ef7e3cfca.test.lua | 2 +-
test/sql-tap/tkt2822.test.lua | 70 +-------------------------
test/sql-tap/tkt3346.test.lua | 2 +-
test/sql-tap/tkt3442.test.lua | 2 +-
test/sql-tap/triggerB.test.lua | 6 +--
test/sql-tap/update.test.lua | 16 +++---
test/sql-tap/view.test.lua | 24 ++-------
test/sql-tap/with1.test.lua | 13 +----
test/sql-tap/with2.test.lua | 4 +-
test/sql/checks.result | 4 +-
test/sql/delete.result | 4 +-
test/sql/drop-table.result | 4 +-
test/sql/gh-2929-primary-key.result | 2 +-
test/sql/gh-3613-idx-alter-update.result | 2 +-
test/sql/gh-3888-values-blob-assert.result | 4 +-
test/sql/icu-upper-lower.result | 2 +-
test/sql/iproto.result | 2 +-
56 files changed, 197 insertions(+), 300 deletions(-)
--
2.7.4
next reply other threads:[~2019-02-15 17:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 17:14 imeevma [this message]
2019-02-15 17:14 ` [tarantool-patches] [PATCH v2 1/2] sql: remove field suppressErr from struct sql imeevma
2019-02-15 17:14 ` [tarantool-patches] [PATCH v2 2/2] sql: rework "no such object" and "object exists" errors imeevma
2019-02-18 12:14 ` [tarantool-patches] " n.pettik
2019-02-19 15:04 ` Konstantin Osipov
2019-02-18 16:51 ` [tarantool-patches] Re: [PATCH v2 0/2] sql: use diag_set() for errors in SQL Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1550250721.git.imeevma@gmail.com \
--to=imeevma@tarantool.org \
--cc=korablev@tarantool.org \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH v2 0/2] sql: use diag_set() for errors in SQL' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox