From: Vladimir Davydov <vdavydov.dev@gmail.com> To: kostja@tarantool.org Cc: tarantool-patches@freelists.org Subject: [PATCH v2 0/3] Improve replication related logging Date: Fri, 15 Feb 2019 15:25:46 +0300 [thread overview] Message-ID: <cover.1550232829.git.vdavydov.dev@gmail.com> (raw) Post-mortem analysis of a replication failure is painful as it is, but with poor logging that we have it is usually nearly to impossible to understand what happened in the frist place. This patch set targets on ameliorating the situration by logging all relevant vclocks and ids on join/subscribe. Changes in v2: - Log all replica id changes, because without them vclocks don't make much sense. - Print remote and local vclocks on subscribe to replica's vclock. It may be useful if master's log rotated. v1: https://www.freelists.org/post/tarantool-patches/PATCH-replication-improve-joinsubscribe-logging Vladimir Davydov (3): vclock: use static buffer to format vclock box: don't set cluster uuid and instance id in initial snapshot replication: improve join/subscribe logging src/box/alter.cc | 3 +- src/box/applier.cc | 17 ++++++++--- src/box/bootstrap.snap | Bin 1911 -> 1831 bytes src/box/box.cc | 27 +++++++++++------ src/box/error.cc | 6 ++-- src/box/gc.c | 6 ++-- src/box/lua/upgrade.lua | 7 +++-- src/box/replication.cc | 17 +++++------ src/box/vclock.c | 64 +++++++++++------------------------------ src/box/vclock.h | 5 ++-- src/box/xlog.c | 16 +++-------- test/box-py/bootstrap.result | 5 ++-- test/box-py/bootstrap.test.py | 16 ++--------- test/replication/misc.result | 9 +++++- test/replication/misc.test.lua | 5 +++- test/unit/vclock.cc | 3 +- 16 files changed, 91 insertions(+), 115 deletions(-) -- 2.11.0
next reply other threads:[~2019-02-15 12:25 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-15 12:25 Vladimir Davydov [this message] 2019-02-15 12:25 ` [PATCH v2 1/3] vclock: use static buffer to format vclock Vladimir Davydov 2019-02-15 12:41 ` Konstantin Osipov 2019-02-15 12:25 ` [PATCH v2 2/3] box: don't set cluster uuid and instance id in initial snapshot Vladimir Davydov 2019-02-15 12:58 ` [tarantool-patches] " Konstantin Osipov 2019-02-15 13:00 ` Konstantin Osipov 2019-02-15 12:25 ` [PATCH v2 3/3] replication: improve join/subscribe logging Vladimir Davydov 2019-02-15 12:59 ` [tarantool-patches] " Konstantin Osipov 2019-02-15 12:26 ` [PATCH v2 0/3] Improve replication related logging Vladimir Davydov 2019-02-15 13:47 ` Vladimir Davydov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1550232829.git.vdavydov.dev@gmail.com \ --to=vdavydov.dev@gmail.com \ --cc=kostja@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [PATCH v2 0/3] Improve replication related logging' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox