Tarantool development patches archive
 help / color / mirror / Atom feed
* [tarantool-patches] [PATCH v5 0/2] Remove useless pragmas
@ 2019-02-13 13:42 Stanislav Zudin
  2019-02-13 13:42 ` [tarantool-patches] [PATCH v5 1/2] sql: remove " Stanislav Zudin
  2019-02-13 13:42 ` [tarantool-patches] [PATCH v5 2/2] sql: remove busy handler Stanislav Zudin
  0 siblings, 2 replies; 3+ messages in thread
From: Stanislav Zudin @ 2019-02-13 13:42 UTC (permalink / raw)
  To: tarantool-patches, korablev; +Cc: Stanislav Zudin

The pragmas "busy_timeout", "query_only" and "read_uncommitted" didn't affect anything
and were removed.
Fixed an error in pragma index_list which caused a segmantation fault.
pragma sql_default_engine accepts only strings.
Thus pragma sql_default_engine('memtx') is a well-formed command,
while pragma sql_default_engine(memtx) or
pragma sql_default_engine("memtx") are considered as an ill-formed and
raise an error.

SQLite's busyHandler functionality and functions sqlite3_sleep(),
sqlite3OsSleep() were not used and were removed.
Removed unreachable error handling.

Issue: https://github.com/tarantool/tarantool/issues/3733
Branch: https://github.com/tarantool/tarantool/tree/stanztt/gh-3733-obsolete-pragmas

Stanislav Zudin (2):
  sql: remove useless pragmas
  sql: remove busy handler

 src/box/sql/main.c                   |  76 ------------
 src/box/sql/os.c                     |   6 -
 src/box/sql/os.h                     |   1 -
 src/box/sql/os_unix.c                |  18 ---
 src/box/sql/pragma.c                 |  51 ++++----
 src/box/sql/pragma.h                 |  46 ++-----
 src/box/sql/sqliteInt.h              |  26 ----
 src/box/sql/vdbe.c                   |   1 -
 test/sql-tap/gh-3733-pragma.test.lua | 177 +++++++++++++++++++++++++++
 9 files changed, 219 insertions(+), 183 deletions(-)
 create mode 100755 test/sql-tap/gh-3733-pragma.test.lua

-- 
2.17.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-02-13 13:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-13 13:42 [tarantool-patches] [PATCH v5 0/2] Remove useless pragmas Stanislav Zudin
2019-02-13 13:42 ` [tarantool-patches] [PATCH v5 1/2] sql: remove " Stanislav Zudin
2019-02-13 13:42 ` [tarantool-patches] [PATCH v5 2/2] sql: remove busy handler Stanislav Zudin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox