From: Stanislav Zudin <szudin@tarantool.org> To: tarantool-patches@freelists.org, korablev@tarantool.org Cc: Stanislav Zudin <szudin@tarantool.org> Subject: [tarantool-patches] [PATCH v5 0/2] Remove useless pragmas Date: Wed, 13 Feb 2019 16:42:47 +0300 [thread overview] Message-ID: <cover.1550064993.git.szudin@tarantool.org> (raw) The pragmas "busy_timeout", "query_only" and "read_uncommitted" didn't affect anything and were removed. Fixed an error in pragma index_list which caused a segmantation fault. pragma sql_default_engine accepts only strings. Thus pragma sql_default_engine('memtx') is a well-formed command, while pragma sql_default_engine(memtx) or pragma sql_default_engine("memtx") are considered as an ill-formed and raise an error. SQLite's busyHandler functionality and functions sqlite3_sleep(), sqlite3OsSleep() were not used and were removed. Removed unreachable error handling. Issue: https://github.com/tarantool/tarantool/issues/3733 Branch: https://github.com/tarantool/tarantool/tree/stanztt/gh-3733-obsolete-pragmas Stanislav Zudin (2): sql: remove useless pragmas sql: remove busy handler src/box/sql/main.c | 76 ------------ src/box/sql/os.c | 6 - src/box/sql/os.h | 1 - src/box/sql/os_unix.c | 18 --- src/box/sql/pragma.c | 51 ++++---- src/box/sql/pragma.h | 46 ++----- src/box/sql/sqliteInt.h | 26 ---- src/box/sql/vdbe.c | 1 - test/sql-tap/gh-3733-pragma.test.lua | 177 +++++++++++++++++++++++++++ 9 files changed, 219 insertions(+), 183 deletions(-) create mode 100755 test/sql-tap/gh-3733-pragma.test.lua -- 2.17.1
next reply other threads:[~2019-02-13 13:43 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-13 13:42 Stanislav Zudin [this message] 2019-02-13 13:42 ` [tarantool-patches] [PATCH v5 1/2] sql: remove " Stanislav Zudin 2019-02-13 13:42 ` [tarantool-patches] [PATCH v5 2/2] sql: remove busy handler Stanislav Zudin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1550064993.git.szudin@tarantool.org \ --to=szudin@tarantool.org \ --cc=korablev@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [tarantool-patches] [PATCH v5 0/2] Remove useless pragmas' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox