From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
To: tarantool-patches@freelists.org, v.shpilevoy@tarantool.org
Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] [PATCH v1 0/4] sql: replace 32 bit column mask
Date: Fri, 8 Feb 2019 15:52:24 +0300 [thread overview]
Message-ID: <cover.1549629707.git.kshcherbatov@tarantool.org> (raw)
Column mask in Tarantool is not just 32 bits greater, but also it
is smarter. When a column with number > 63 is added to the mask,
the only last bit (64th) is set indicating the overflow.
SQLite mask in such a case just resets the whole mask in -1.
Reworked sqlite code to use Tarantool mask helpers everywhere.
Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3571-sql-column-mask-64
Issue: https://github.com/tarantool/tarantool/issues/3571
Kirill Shcherbatov (4):
box: introduce new helpers in column_mask.h
sql: use 64b bitmasks instead of 32b where possible
sql: got rid of redundant MASKBIT32 definition
sql: got rid of redundant bitmask helpers
src/box/alter.cc | 10 +---
src/box/column_mask.h | 39 +++++++++++---
src/box/sql/delete.c | 8 ++-
src/box/sql/expr.c | 53 ++++++++++---------
src/box/sql/resolve.c | 31 +++--------
src/box/sql/sqliteInt.h | 71 +++++++++++---------------
src/box/sql/trigger.c | 14 ++---
src/box/sql/update.c | 21 ++++----
src/box/sql/vdbeaux.c | 7 ++-
src/box/sql/where.c | 110 ++++++++++++++++++----------------------
src/box/sql/whereInt.h | 3 +-
11 files changed, 175 insertions(+), 192 deletions(-)
--
2.20.1
next reply other threads:[~2019-02-08 12:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 12:52 Kirill Shcherbatov [this message]
2019-02-08 12:52 ` [tarantool-patches] [PATCH v1 1/4] box: introduce new helpers in column_mask.h Kirill Shcherbatov
2019-02-15 17:05 ` [tarantool-patches] " Vladislav Shpilevoy
2019-02-20 13:42 ` Kirill Shcherbatov
2019-02-22 17:51 ` Vladislav Shpilevoy
2019-02-22 18:01 ` Konstantin Osipov
2019-02-22 18:22 ` Konstantin Osipov
2019-02-08 12:52 ` [tarantool-patches] [PATCH v1 2/4] sql: use 64b bitmasks instead of 32b where possible Kirill Shcherbatov
2019-02-15 17:05 ` [tarantool-patches] " Vladislav Shpilevoy
2019-02-20 13:42 ` Kirill Shcherbatov
2019-02-08 12:52 ` [tarantool-patches] [PATCH v1 3/4] sql: got rid of redundant MASKBIT32 definition Kirill Shcherbatov
2019-02-15 17:05 ` [tarantool-patches] " Vladislav Shpilevoy
2019-02-20 13:42 ` Kirill Shcherbatov
2019-02-08 12:52 ` [tarantool-patches] [PATCH v1 4/4] sql: got rid of redundant bitmask helpers Kirill Shcherbatov
2019-02-15 17:05 ` [tarantool-patches] " Vladislav Shpilevoy
2019-02-20 13:42 ` Kirill Shcherbatov
2019-02-22 17:52 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1549629707.git.kshcherbatov@tarantool.org \
--to=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [tarantool-patches] [PATCH v1 0/4] sql: replace 32 bit column mask' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox