From: Georgy Kirichenko <georgy@tarantool.org> To: tarantool-patches@freelists.org Cc: Georgy Kirichenko <georgy@tarantool.org> Subject: [tarantool-patches] [PATCH v2 0/2] Do not promote vclocks in case of failure Date: Thu, 7 Feb 2019 20:27:29 +0300 [thread overview] Message-ID: <cover.1549556742.git.georgy@tarantool.org> (raw) Promote tx and wal vclock only if corresponding row was successfully written to wal. This prevents tarantool from skipping rows in case of replication errors as well as from making lsn gaps after IO errors. Branch: https://github.com/tarantool/tarantool/tree/g.kirichenko/gh-2283-dont-skip-rows-after-errors Issue: https://github.com/tarantool/tarantool/issues/2283 Changes in v2: - commits 2 and 3 are squashed - test fixed according to review - comment fixed according to review Georgy Kirichenko (2): Do not promote wal vclock for failed writes Promote replicaset.vclock only after wal src/box/applier.cc | 46 +-- src/box/wal.c | 67 ++-- test/box/errinj.result | 59 +++ test/box/errinj.test.lua | 20 ++ test/replication/skip_conflict_row.result | 63 ++++ test/replication/skip_conflict_row.test.lua | 20 ++ test/xlog/errinj.result | 1 - test/xlog/panic_on_lsn_gap.result | 377 -------------------- test/xlog/panic_on_lsn_gap.test.lua | 136 ------- 9 files changed, 210 insertions(+), 579 deletions(-) delete mode 100644 test/xlog/panic_on_lsn_gap.result delete mode 100644 test/xlog/panic_on_lsn_gap.test.lua -- 2.20.1
next reply other threads:[~2019-02-07 17:25 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-07 17:27 Georgy Kirichenko [this message] 2019-02-07 17:27 ` [tarantool-patches] [PATCH v2 1/2] Do not promote wal vclock for failed writes Georgy Kirichenko 2019-02-08 9:57 ` Vladimir Davydov 2019-02-07 17:27 ` [tarantool-patches] [PATCH v2 2/2] Promote replicaset.vclock only after wal Georgy Kirichenko 2019-02-08 10:09 ` [tarantool-patches] [PATCH v2 0/2] Do not promote vclocks in case of failure Vladimir Davydov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1549556742.git.georgy@tarantool.org \ --to=georgy@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [tarantool-patches] [PATCH v2 0/2] Do not promote vclocks in case of failure' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox