Tarantool development patches archive
 help / color / mirror / Atom feed
From: Nikita Pettik <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org, Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] [PATCH 0/8] Eliminate affinity from source code
Date: Fri, 28 Dec 2018 11:34:44 +0200	[thread overview]
Message-ID: <cover.1545987214.git.korablev@tarantool.org> (raw)

Branch: https://github.com/tarantool/tarantool/tree/np/gh-3698-eliminate-affinity
Issue:
https://github.com/tarantool/tarantool/issues/3698
https://github.com/tarantool/tarantool/issues/3886

Main purpose of current patch-set is to remove affinity from source
code. We are starting from introducing itermediate converstors
from affinity to field type and vice versa. Then, step-by-step we
are replacing affinity usages with field type. Non-trivial part of
this patch-set is removing numeric affinity (see third patch in
series and commit message).

It worth noting that current patch-set also fixes issue connected
with invisible to query optimizer indexes, which are created from
Lua: to choose suitable index QO checked affinity compatibility of
key part and field def. As a result, indexes created without affinity
field couldn't be used to process query.

Nikita Pettik (8):
  sql: remove SQLITE_ENABLE_UPDATE_DELETE_LIMIT define
  sql: use field type instead of affinity for type_def
  sql: remove numeric affinity
  sql: replace affinity with field type for func
  sql: replace field type with affinity for VDBE runtime
  sql: replace affinity with field type in struct Expr
  sql: clean-up affinity from SQL source code
  Remove affinity from field definition

 src/box/field_def.c                  |  20 ---
 src/box/field_def.h                  |  18 ---
 src/box/lua/lua_sql.c                |  12 +-
 src/box/sql.c                        |  14 +-
 src/box/sql/analyze.c                |   5 +-
 src/box/sql/build.c                  |  19 +--
 src/box/sql/date.c                   |  17 ++-
 src/box/sql/delete.c                 |  16 +-
 src/box/sql/expr.c                   | 281 ++++++++++++++++-------------------
 src/box/sql/fkey.c                   |   8 +-
 src/box/sql/func.c                   |  91 ++++++------
 src/box/sql/insert.c                 |  60 +++-----
 src/box/sql/main.c                   |   4 +-
 src/box/sql/parse.y                  |  38 +++--
 src/box/sql/resolve.c                |  24 +--
 src/box/sql/select.c                 |  29 ++--
 src/box/sql/sqliteInt.h              | 107 +++++--------
 src/box/sql/update.c                 |  17 +--
 src/box/sql/vdbe.c                   | 120 +++++++--------
 src/box/sql/vdbeInt.h                |   2 +-
 src/box/sql/vdbeaux.c                |  19 ++-
 src/box/sql/vdbemem.c                |  37 ++---
 src/box/sql/where.c                  |  37 ++---
 src/box/sql/whereInt.h               |   3 +-
 src/box/sql/wherecode.c              |  59 +++-----
 src/box/sql/whereexpr.c              |  34 ++---
 test/sql-tap/cast.test.lua           |  10 +-
 test/sql-tap/lua-tables.test.lua     |  38 ++++-
 test/sql-tap/tkt-80e031a00f.test.lua |  12 +-
 test/sql/iproto.result               |   2 +-
 test/sql/types.result                |  15 +-
 test/sql/upgrade.result              |   6 +-
 32 files changed, 516 insertions(+), 658 deletions(-)

-- 
2.15.1

             reply	other threads:[~2018-12-28  9:34 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-28  9:34 Nikita Pettik [this message]
2018-12-28  9:34 ` [tarantool-patches] [PATCH 1/8] sql: remove SQLITE_ENABLE_UPDATE_DELETE_LIMIT define Nikita Pettik
2018-12-29 17:42   ` [tarantool-patches] " Vladislav Shpilevoy
2019-01-16 14:25     ` n.pettik
2018-12-28  9:34 ` [tarantool-patches] [PATCH 2/8] sql: use field type instead of affinity for type_def Nikita Pettik
2018-12-29 17:42   ` [tarantool-patches] " Vladislav Shpilevoy
2019-01-16 14:26     ` n.pettik
2018-12-28  9:34 ` [tarantool-patches] [PATCH 3/8] sql: remove numeric affinity Nikita Pettik
2018-12-29  9:01   ` [tarantool-patches] " Konstantin Osipov
2018-12-29 17:42   ` Vladislav Shpilevoy
2019-01-09  8:26     ` Konstantin Osipov
2019-01-16 14:26     ` n.pettik
2019-01-22 15:41       ` Vladislav Shpilevoy
2019-01-28 16:39         ` n.pettik
2019-01-30 13:04           ` Vladislav Shpilevoy
2019-02-01 16:39             ` n.pettik
2019-01-09  8:20   ` Konstantin Osipov
2018-12-28  9:34 ` [tarantool-patches] [PATCH 4/8] sql: replace affinity with field type for func Nikita Pettik
2018-12-28  9:34 ` [tarantool-patches] [PATCH 5/8] sql: replace field type with affinity for VDBE runtime Nikita Pettik
2018-12-29 17:42   ` [tarantool-patches] " Vladislav Shpilevoy
2019-01-16 14:26     ` n.pettik
2019-01-22 15:41       ` Vladislav Shpilevoy
2019-01-28 16:39         ` n.pettik
2019-01-30 13:04           ` Vladislav Shpilevoy
2019-02-01 16:39             ` n.pettik
2019-02-05 15:08               ` Vladislav Shpilevoy
2019-02-05 17:46                 ` n.pettik
2018-12-28  9:34 ` [tarantool-patches] [PATCH 6/8] sql: replace affinity with field type in struct Expr Nikita Pettik
2018-12-29 17:42   ` [tarantool-patches] " Vladislav Shpilevoy
2019-01-16 14:26     ` n.pettik
2019-01-22 15:41       ` Vladislav Shpilevoy
2019-01-28 16:39         ` n.pettik
2019-01-30 13:04           ` Vladislav Shpilevoy
2019-02-01 16:39             ` n.pettik
2019-02-05 15:08               ` Vladislav Shpilevoy
2019-02-05 17:46                 ` n.pettik
2018-12-28  9:34 ` [tarantool-patches] [PATCH 7/8] sql: clean-up affinity from SQL source code Nikita Pettik
2018-12-29 17:42   ` [tarantool-patches] " Vladislav Shpilevoy
2019-01-16 14:26     ` n.pettik
2019-01-22 15:41       ` Vladislav Shpilevoy
2019-01-28 16:40         ` n.pettik
2019-01-30 13:04           ` Vladislav Shpilevoy
2019-02-01 16:39             ` n.pettik
2019-02-05 15:08               ` Vladislav Shpilevoy
2019-02-05 17:46                 ` n.pettik
2018-12-28  9:34 ` [tarantool-patches] [PATCH 8/8] Remove affinity from field definition Nikita Pettik
2019-02-05 19:41 ` [tarantool-patches] Re: [PATCH 0/8] Eliminate affinity from source code Vladislav Shpilevoy
2019-02-08 13:37 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1545987214.git.korablev@tarantool.org \
    --to=korablev@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [tarantool-patches] [PATCH 0/8] Eliminate affinity from source code' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox