From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
To: tarantool-patches@freelists.org, vdavydov.dev@gmail.com
Cc: kostja@tarantool.org, Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [PATCH v6 0/4] box: JSON tree class
Date: Thu, 6 Dec 2018 11:42:27 +0300 [thread overview]
Message-ID: <cover.1544084229.git.kshcherbatov@tarantool.org> (raw)
http://github.com/tarantool/tarantool/tree/kshch/gh-1012-json-tree
https://github.com/tarantool/tarantool/issues/1012
Preparatory patch set for JSON indexes story.
Implemented JSON tree class is used for organizing JSON tokens
produced by a lexer in a tree-like structure reflecting a JSON
document structure.
Refactored json_lexer class to use index_base to emmit tokens
being ready to insert in JSON tree.
Refactored tuple_format to use the tree JSON class for working
with first-level fields to works with all fields in unified way.
Introduced help routines json_path_validate and json_path_cmp.
The third path "box: manage format fields with JSON tree class"
triggers a bug #3772 that is already on review
kshch/gh-3772-dirty-memory-access. Source branch has
cherry-picked fix.
General information of difference from previous version of
patch-set:
- new patch "make index_base support for json_lexer" allows to
do not carry for LUA index base during token insertion
- significantly improved comments, many minor refactoring
- new consistency assertions, e.g. that no fields attached during
token detach.
- reworked iterators
- _slowpath version for json_tree_lookup to improve performance
for numerical levels
- new tests
- reworked json_path_cmp, introduced json_path_validate
- rebased on up-to-date 2.1 and cherry-picked #3772 fix
Kirill Shcherbatov (4):
lib: make index_base support for json_lexer
lib: implement JSON tree class for json library
box: manage format fields with JSON tree class
lib: introduce json_path_cmp, json_path_validate
src/box/sql.c | 18 +-
src/box/sql/build.c | 5 +-
src/box/tuple.c | 10 +-
src/box/tuple_format.c | 138 +++++++++------
src/box/tuple_format.h | 49 +++++-
src/box/vy_stmt.c | 4 +-
src/lib/json/CMakeLists.txt | 1 +
src/lib/json/json.c | 290 +++++++++++++++++++++++++++++++-
src/lib/json/json.h | 326 +++++++++++++++++++++++++++++++++++-
test/engine/tuple.result | 4 +-
test/unit/json_path.c | 302 +++++++++++++++++++++++++++++++--
test/unit/json_path.result | 92 ++++++++--
12 files changed, 1141 insertions(+), 98 deletions(-)
--
2.19.2
next reply other threads:[~2018-12-06 8:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 8:42 Kirill Shcherbatov [this message]
2018-12-06 8:42 ` [PATCH v6 1/4] lib: make index_base support for json_lexer Kirill Shcherbatov
2018-12-10 17:34 ` Vladimir Davydov
2018-12-06 8:42 ` [PATCH v6 2/4] lib: implement JSON tree class for json library Kirill Shcherbatov
2018-12-10 17:36 ` Vladimir Davydov
2018-12-06 8:42 ` [PATCH v6 3/4] box: manage format fields with JSON tree class Kirill Shcherbatov
2018-12-11 9:52 ` Vladimir Davydov
2018-12-06 8:42 ` [PATCH v6 4/4] lib: introduce json_path_cmp, json_path_validate Kirill Shcherbatov
2018-12-10 17:38 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1544084229.git.kshcherbatov@tarantool.org \
--to=kshcherbatov@tarantool.org \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [PATCH v6 0/4] box: JSON tree class' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox