Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org
Cc: vdavydov.dev@gmail.com
Subject: [PATCH v2 00/11] SWIM preparation
Date: Wed,  5 Dec 2018 00:28:45 +0300	[thread overview]
Message-ID: <cover.1543958698.git.v.shpilevoy@tarantool.org> (raw)

SWIM is going to use evio to bind to an address, specified by a
user. Evio encapsulates bind/rebind, diagnostics, socket family.

But evio is C++ and SWIM is C. The patchset converts evio to C
alongside with sio, which is used in evio.

During conversion several not critical bugs were found and fixed
in separate commits.

Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-3234-swim-preparation
Issue: https://github.com/tarantool/tarantool/issues/3234

V1: https://www.freelists.org/post/tarantool-patches/PATCH-0011-SWIM-preparation

Changes in v2:
- Removed unnecessary refactoring to save git history;
- Changed a way how to say that a sio error is critical;
- Dropped a bugfix about negative size_t.

Vladislav Shpilevoy (11):
  sio: remove unused functions
  sio: treat EADDRINUSE in sio_listen as error
  sio: remove exceptions
  sio: make code compatible with C
  sio: turn into C
  evio: make on_accept be nothrow
  coio: fix double close of a file descriptor
  evio: remove exceptions
  coio: fix file descriptor leak on accept
  evio: make code C compatible
  evio: turn nto c

 src/CMakeLists.txt      |   4 +-
 src/box/iproto.cc       |  46 ++++----
 src/coio.cc             |  59 ++++++-----
 src/{evio.cc => evio.c} | 183 ++++++++++++++++----------------
 src/evio.h              |  41 +++++---
 src/{sio.cc => sio.c}   | 226 +++++++---------------------------------
 src/sio.h               |  66 ++----------
 7 files changed, 221 insertions(+), 404 deletions(-)
 rename src/{evio.cc => evio.c} (76%)
 rename src/{sio.cc => sio.c} (64%)

-- 
2.17.2 (Apple Git-113)

             reply	other threads:[~2018-12-04 21:28 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-04 21:28 Vladislav Shpilevoy [this message]
2018-12-04 21:28 ` [PATCH v2 01/11] sio: remove unused functions Vladislav Shpilevoy
2018-12-09 12:10   ` Vladimir Davydov
2018-12-04 21:28 ` [PATCH v2 10/11] evio: make code C compatible Vladislav Shpilevoy
2018-12-05  8:56   ` Vladimir Davydov
2018-12-05 20:07     ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-04 21:28 ` [PATCH v2 11/11] evio: turn nto c Vladislav Shpilevoy
2018-12-04 21:28 ` [PATCH v2 02/11] sio: treat EADDRINUSE in sio_listen as error Vladislav Shpilevoy
2018-12-09 12:57   ` Vladimir Davydov
2018-12-10 15:36     ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-04 21:28 ` [PATCH v2 03/11] sio: remove exceptions Vladislav Shpilevoy
2018-12-09 12:54   ` Vladimir Davydov
2018-12-10 15:37     ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-11  8:44       ` Vladimir Davydov
2018-12-04 21:28 ` [PATCH v2 04/11] sio: make code compatible with C Vladislav Shpilevoy
2018-12-05  8:57   ` Vladimir Davydov
2018-12-05 20:07     ` [tarantool-patches] " Vladislav Shpilevoy
2018-12-04 21:28 ` [PATCH v2 05/11] sio: turn into C Vladislav Shpilevoy
2018-12-04 21:28 ` [PATCH v2 06/11] evio: make on_accept be nothrow Vladislav Shpilevoy
2018-12-04 21:28 ` [PATCH v2 07/11] coio: fix double close of a file descriptor Vladislav Shpilevoy
2018-12-04 21:28 ` [PATCH v2 08/11] evio: remove exceptions Vladislav Shpilevoy
2018-12-04 21:28 ` [PATCH v2 09/11] coio: fix file descriptor leak on accept Vladislav Shpilevoy
2018-12-11  8:47 ` [PATCH v2 00/11] SWIM preparation Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1543958698.git.v.shpilevoy@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [PATCH v2 00/11] SWIM preparation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox