Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org
Cc: vdavydov.dev@gmail.com
Subject: [PATCH 0/2] Move info to src/ for SWIM
Date: Tue,  4 Dec 2018 00:47:04 +0300	[thread overview]
Message-ID: <cover.1543873210.git.v.shpilevoy@tarantool.org> (raw)

First commit has enough explanation of this patchset but nonetheless
it is formally required so there it is.

SWIM is a forthcoming independent module which is going to live in
src/lib. And it will have a method swim.info() which dumps SWIM
state to Lua.

But SWIM will be written on C and should not depend on Lua. To
resolve the problem the patchset moves src/box/info to src/info
to make it usable in SWIM.

src/box/info is an interface which allows to dump something to Lua
without getting in touch with Lua API.

Second commit in the patchset removes some false comments about info
interface stating that it throws C++ exceptions.

Branch: http://github.com/tarantool/tarantool/tree/gerold103/swim-preparation-info
Issue: https://github.com/tarantool/tarantool/issues/3234

Vladislav Shpilevoy (2):
  box: move info_handler interface into src/info
  info: remove false comments from src/info.h

 src/CMakeLists.txt   |   1 +
 src/box/lua/index.c  |   4 +-
 src/box/lua/info.c   |  78 +------------------------------
 src/box/lua/sql.c    |   4 +-
 src/box/lua/stat.c   |   4 +-
 src/box/sql.c        |   2 +-
 src/{box => }/info.h |  13 ++----
 src/lua/info.c       | 107 +++++++++++++++++++++++++++++++++++++++++++
 src/lua/info.h       |  49 ++++++++++++++++++++
 9 files changed, 169 insertions(+), 93 deletions(-)
 rename src/{box => }/info.h (91%)
 create mode 100644 src/lua/info.c
 create mode 100644 src/lua/info.h

-- 
2.17.2 (Apple Git-113)

             reply	other threads:[~2018-12-03 21:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-03 21:47 Vladislav Shpilevoy [this message]
2018-12-03 21:47 ` [PATCH 1/2] box: move info_handler interface into src/info Vladislav Shpilevoy
2018-12-04  8:59   ` Vladimir Davydov
2018-12-03 21:47 ` [PATCH 2/2] info: remove false comments from src/info.h Vladislav Shpilevoy
2018-12-04  9:02   ` Vladimir Davydov
2018-12-04  9:11     ` Vladislav Shpilevoy
2018-12-04  9:46       ` Vladimir Davydov
2018-12-04 10:17         ` Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1543873210.git.v.shpilevoy@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [PATCH 0/2] Move info to src/ for SWIM' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox