Tarantool development patches archive
 help / color / mirror / Atom feed
From: imeevma@tarantool.org
To: tarantool-patches@freelists.org, v.shpilevoy@tarantool.org
Subject: [tarantool-patches] [PATCH v2 0/2] sql: proper check for index in sqlite3Insert()
Date: Thu, 15 Nov 2018 15:09:19 +0300	[thread overview]
Message-ID: <cover.1542282499.git.imeevma@gmail.com> (raw)

In case when different fibers try to "INSERT INTO table" and
"DROP TABLE table" at the same time it is possible to get
SEGMENTATION FAULT because INSERT tried to use nonexistent index.

Patch 1 adds a check for index in given space and do some
refactoring.

Patch 2 do some refactoring.

Changes in v2:
 - Check that index exists instead of do less work if it doesn't.
 - Refactoring: reduced "struct Table" usage.
 - Refactoring: removed space_column_default_expr().

https://github.com/tarantool/tarantool/issues/3780
https://github.com/tarantool/tarantool/tree/imeevma/gh-3780-proper-index-check

Mergen Imeev (1):
  sql: proper check for index in sqlite3Insert()

Vladislav Shpilevoy (1):
  sql: remove space_column_default_expr()

 src/box/sql.c            | 14 ----------
 src/box/sql.h            | 11 --------
 src/box/sql/insert.c     | 68 +++++++++++++++++++++++-------------------------
 test/sql/errinj.result   | 33 +++++++++++++++++++++++
 test/sql/errinj.test.lua | 12 +++++++++
 5 files changed, 78 insertions(+), 60 deletions(-)

-- 
2.7.4

             reply	other threads:[~2018-11-15 12:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15 12:09 imeevma [this message]
2018-11-15 12:09 ` [tarantool-patches] [PATCH v2 1/2] " imeevma
2018-11-15 13:47   ` [tarantool-patches] " n.pettik
2018-11-15 12:09 ` [tarantool-patches] [PATCH v2 2/2] sql: remove space_column_default_expr() imeevma
2018-11-15 13:47   ` [tarantool-patches] " n.pettik
2018-11-15 12:27 ` [tarantool-patches] Re: [PATCH v2 0/2] sql: proper check for index in sqlite3Insert() Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1542282499.git.imeevma@gmail.com \
    --to=imeevma@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [tarantool-patches] [PATCH v2 0/2] sql: proper check for index in sqlite3Insert()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox