From: Vladimir Davydov <vdavydov.dev@gmail.com> To: kostja@tarantool.org Cc: tarantool-patches@freelists.org Subject: [PATCH v2 0/4] Delete old WAL files if running out of disk space Date: Tue, 23 Oct 2018 20:26:30 +0300 [thread overview] Message-ID: <cover.1540314925.git.vdavydov.dev@gmail.com> (raw) If a replica permanently stops working for some reason, it will pin WAL files it would need to resume until it is deleted from the _cluster system space or the master is restarted. This happens in production when an admin drops a replica and forgets to remove it from the master, and this is quite annoying, because it may result in ENOSPC errors on the master. This patch set attempts to mitigate this problem by making the WAL thread delete old WAL files and shoot off old replicas automatically when it runs out of disk space. https://github.com/tarantool/tarantool/issues/3397 https://github.com/tarantool/tarantool/commits/dv/gh-3397-wal-auto-deletion Changes in v2: - Simplify WAL fallocate logic and move it from xlog.c (xlog_fallocate) to wal.c (wal_fallocate), because it's a business of the WAL thread. Now we simply fallocate() in 1 MB blocks. - Rework xdir_collect_garbage(): pass flags instead of bool + number of files to delete; also, introduce xdir_has_garbage() to make the code more straightforward. v1: https://www.freelists.org/post/tarantool-patches/PATCH-05-Delete-old-WAL-files-if-running-out-of-disk-space Vladimir Davydov (4): xlog: turn use_coio argument of xdir_collect_garbage to flags wal: preallocate disk space before writing rows wal: notify watchers about wal file removal wal: delete old wal files when running out of disk space CMakeLists.txt | 1 + src/box/box.cc | 9 +- src/box/gc.c | 67 +++++++++- src/box/gc.h | 31 +++++ src/box/journal.c | 1 + src/box/journal.h | 4 + src/box/memtx_engine.c | 2 +- src/box/relay.cc | 8 +- src/box/txn.c | 1 + src/box/vy_log.c | 2 +- src/box/wal.c | 152 ++++++++++++++++++---- src/box/wal.h | 35 +++-- src/box/xlog.c | 59 ++++++++- src/box/xlog.h | 60 ++++++++- src/box/xrow.h | 13 ++ src/errinj.h | 1 + src/trivia/config.h.cmake | 1 + test/box/errinj.result | 18 +-- test/replication/gc_no_space.result | 234 ++++++++++++++++++++++++++++++++++ test/replication/gc_no_space.test.lua | 103 +++++++++++++++ test/replication/suite.ini | 2 +- 21 files changed, 743 insertions(+), 61 deletions(-) create mode 100644 test/replication/gc_no_space.result create mode 100644 test/replication/gc_no_space.test.lua -- 2.11.0
next reply other threads:[~2018-10-23 17:26 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-23 17:26 Vladimir Davydov [this message] 2018-10-23 17:26 ` [PATCH v2 1/4] xlog: turn use_coio argument of xdir_collect_garbage to flags Vladimir Davydov 2018-10-23 18:17 ` Konstantin Osipov 2018-10-24 11:21 ` Vladimir Davydov 2018-10-23 17:26 ` [PATCH v2 2/4] wal: preallocate disk space before writing rows Vladimir Davydov 2018-10-23 18:33 ` Konstantin Osipov 2018-10-24 9:54 ` Vladimir Davydov 2018-10-23 17:26 ` [PATCH v2 3/4] wal: notify watchers about wal file removal Vladimir Davydov 2018-10-23 17:26 ` [PATCH v2 4/4] wal: delete old wal files when running out of disk space Vladimir Davydov 2018-10-23 18:46 ` Konstantin Osipov 2018-10-24 9:51 ` Vladimir Davydov 2018-10-24 16:53 ` Konstantin Osipov 2018-10-25 8:31 ` Vladimir Davydov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1540314925.git.vdavydov.dev@gmail.com \ --to=vdavydov.dev@gmail.com \ --cc=kostja@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [PATCH v2 0/4] Delete old WAL files if running out of disk space' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox