From: Kirill Yukhin <kyukhin@tarantool.org>
To: korablev@tarantool.org
Cc: tarantool-patches@freelists.org, Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] [PATCH v2 0/2] sql: check read access while executing SQL query
Date: Fri, 12 Oct 2018 14:38:17 +0300 [thread overview]
Message-ID: <cover.1539344128.git.kyukhin@tarantool.org> (raw)
This patchset intended to fix checking of read priviledges
while executing SQL queries. To do so, box interface for
fetching space pointer by name was replaced by requesting
(created in 1st patch) dedicated mapping of space name to
space pointer. This allows SQL machinery to read from system
spaces w/o any access checks. Actual check is performed by
IteratorOpen op-code.
https://github.com/tarantool/tarantool/commits/kyukhin/gh-2362-sql-read-access-check
https://github.com/tarantool/tarantool/issues/2362
Kirill Yukhin (2):
Add space names cache
sql: check read access while executing SQL query
src/box/alter.cc | 18 +--
src/box/schema.cc | 123 +++++++++++++++---
src/box/schema.h | 12 +-
src/box/sql/alter.c | 11 +-
src/box/sql/analyze.c | 44 +++----
src/box/sql/build.c | 57 +++-----
src/box/sql/delete.c | 26 ++--
src/box/sql/insert.c | 7 +-
src/box/sql/pragma.c | 32 ++---
src/box/sql/vdbe.c | 5 +
test/box/stat.result | 6 +-
test/sql/gh-2362-select-access-rights.result | 110 ++++++++++++++++
.../sql/gh-2362-select-access-rights.test.lua | 42 ++++++
13 files changed, 353 insertions(+), 140 deletions(-)
create mode 100644 test/sql/gh-2362-select-access-rights.result
create mode 100644 test/sql/gh-2362-select-access-rights.test.lua
--
2.19.1
next reply other threads:[~2018-10-12 11:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 11:38 Kirill Yukhin [this message]
2018-10-12 11:38 ` [tarantool-patches] [PATCH v2 1/2] Add space names cache Kirill Yukhin
2018-10-15 10:08 ` Vladimir Davydov
2018-10-24 13:34 ` Kirill Yukhin
2018-10-12 11:38 ` [tarantool-patches] [PATCH v2 2/2] sql: check read access while executing SQL query Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1539344128.git.kyukhin@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH v2 0/2] sql: check read access while executing SQL query' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox