Tarantool development patches archive
 help / color / mirror / Atom feed
From: AKhatskevich <avkhatskevich@tarantool.org>
To: korablev@tarantool.org, tarantool-patches@freelists.org
Subject: [tarantool-patches] [PATCH 0/3] Delete foreign_keys and ignore_check_constraints pragmas
Date: Tue,  2 Oct 2018 13:48:33 +0300	[thread overview]
Message-ID: <cover.1538476785.git.avkhatskevich@tarantool.org> (raw)

Issue: https://github.com/tarantool/tarantool/issues/3696
Branch: https://github.com/tarantool/tarantool/tree/kh/gh-3696-delete-pragmas-2

Those pragmas let a user turn off constraint checks.
They are considered useless and dangerous.

AKhatskevich (3):
  sql: delete unused code
  sql: delete foreign_keys pragma
  sql: delete ignore_check_constraints pragma

 src/box/sql.c                             |   3 +-
 src/box/sql/CMakeLists.txt                |   1 -
 src/box/sql/fkey.c                        |  21 +--
 src/box/sql/insert.c                      |   7 +-
 src/box/sql/main.c                        | 291 ------------------------------
 src/box/sql/pragma.h                      |  14 --
 src/box/sql/sqliteInt.h                   |  19 +-
 test/sql-tap/check.test.lua               |  15 +-
 test/sql-tap/tkt-b1d3a2e531.test.lua      |   8 +-
 test/sql-tap/triggerC.test.lua            |   5 +-
 test/sql/transitive-transactions.result   |   3 -
 test/sql/transitive-transactions.test.lua |   1 -
 12 files changed, 12 insertions(+), 376 deletions(-)

-- 
2.14.1

             reply	other threads:[~2018-10-02 10:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-02 10:48 AKhatskevich [this message]
2018-10-02 10:48 ` [tarantool-patches] [PATCH 1/3] sql: delete unused code AKhatskevich
2018-10-02 13:36   ` [tarantool-patches] " n.pettik
2018-10-04 15:16     ` Alex Khatskevich
2018-10-02 10:48 ` [tarantool-patches] [PATCH 2/3] sql: delete foreign_keys pragma AKhatskevich
2018-10-02 13:36   ` [tarantool-patches] " n.pettik
2018-10-04 15:16     ` Alex Khatskevich
2018-10-02 10:48 ` [tarantool-patches] [PATCH 3/3] sql: delete ignore_check_constraints pragma AKhatskevich
2018-10-02 13:36   ` [tarantool-patches] " n.pettik
2018-10-04 15:16     ` Alex Khatskevich
2018-10-04 16:27 ` [tarantool-patches] Re: [PATCH 0/3] Delete foreign_keys and ignore_check_constraints pragmas n.pettik
2018-10-05  7:15 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1538476785.git.avkhatskevich@tarantool.org \
    --to=avkhatskevich@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [tarantool-patches] [PATCH 0/3] Delete foreign_keys and ignore_check_constraints pragmas' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox