From: Serge Petrenko <sergepetrenko@tarantool.org> To: vdavydov.dev@gmail.com Cc: tarantool-patches@freelists.org, Serge Petrenko <sergepetrenko@tarantool.org> Subject: [PATCH v2 0/2] fix bodiless requests handling. Date: Mon, 24 Sep 2018 17:08:07 +0300 [thread overview] Message-ID: <cover.1537797732.git.sergepetrenko@tarantool.org> (raw) The first patch fixes an error when trying to parse a bodiless request such as IPROTO_NOP in `tarantoolctl cat` and `tarantoolctl play`. Now cat displays such requests correctly and play ignores them. https://github.com/tarantool/tarantool/issues/3675 The second patch fixes parsing xlogs containing transactions with empty body requests. Such requests weren't handled correctly which lead to header of the next request become body of a no-op request. This messed up recovery and `tarantoolctl cat`. Both fixed. https://github.com/tarantool/tarantool/issues/3678 Branch: https://github.com/tarantool/tarantool/tree/sp/gh-3675-tarantoolctl-cat-empty-body Changes in v2: - make sure that tarantoolctl cat and play stops on all records with lsn >= to, even the ones that have to be skipped. - move NOP recovery test to box/before_replace.test.lua - decided to ignore old xlogs with NOPS with body. - simplify check for NOP in xrow_header_decode() Serge Petrenko (2): tarantoolctl: fix cat and play for empty body requests recovery: fix incorrect handling of empty-body requests. extra/dist/tarantoolctl.in | 32 ++++++++++++++++++------------ src/box/xrow.c | 3 ++- test/app-tap/tarantoolctl.test.lua | 14 ++++++++++--- test/box/before_replace.result | 25 ++++++++++++++++++++--- test/box/before_replace.test.lua | 14 ++++++++++--- 5 files changed, 65 insertions(+), 23 deletions(-) -- 2.17.1 (Apple Git-112)
next reply other threads:[~2018-09-24 14:08 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-24 14:08 Serge Petrenko [this message] 2018-09-24 14:08 ` [PATCH v2 1/2] tarantoolctl: fix cat and play for empty body requests Serge Petrenko 2018-09-25 22:31 ` [tarantool-patches] " Konstantin Osipov 2018-09-24 14:08 ` [PATCH v2 2/2] recovery: fix incorrect handling of empty-body requests Serge Petrenko 2018-09-25 22:33 ` [tarantool-patches] " Konstantin Osipov 2018-09-25 14:37 ` [PATCH v2 0/2] fix bodiless requests handling Vladimir Davydov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1537797732.git.sergepetrenko@tarantool.org \ --to=sergepetrenko@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=vdavydov.dev@gmail.com \ --subject='Re: [PATCH v2 0/2] fix bodiless requests handling.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox