From: Serge Petrenko <sergepetrenko@tarantool.org>
To: vdavydov.dev@gmail.com
Cc: tarantool-patches@freelists.org,
Serge Petrenko <sergepetrenko@tarantool.org>
Subject: [PATCH 0/2] fix bodiless requests handling.
Date: Fri, 14 Sep 2018 17:36:39 +0300 [thread overview]
Message-ID: <cover.1536934854.git.sergepetrenko@tarantool.org> (raw)
The first patch fixes an error when trying to parse a bodiless request
such as IPROTO_NOP in `tarantoolctl cat` and `tarantoolctl play`.
Now cat displays such requests correctly and play ignores them.
https://github.com/tarantool/tarantool/issues/3675
The second patch fixes parsing xlogs containing transactions with
empty body requests. Such requests weren't handled correctly which lead to
header of the next request become body of a no-op request. This messed up recovery
and `tarantoolctl cat`. Both fixed.
https://github.com/tarantool/tarantool/issues/3678
Branch:
https://github.com/tarantool/tarantool/tree/sp/gh-3675-tarantoolctl-cat-empty-body
Serge Petrenko (2):
tarantoolctl: fix cat and play for empty body requests
recovery: fix incorrect handling of empty-body requests.
extra/dist/tarantoolctl.in | 11 +++---
src/box/xrow.c | 6 +++-
test/app-tap/tarantoolctl.test.lua | 14 ++++++--
test/xlog/recover_nop.result | 72 ++++++++++++++++++++++++++++++++++++++
test/xlog/recover_nop.test.lua | 28 +++++++++++++++
5 files changed, 123 insertions(+), 8 deletions(-)
create mode 100644 test/xlog/recover_nop.result
create mode 100644 test/xlog/recover_nop.test.lua
--
2.15.2 (Apple Git-101.1)
next reply other threads:[~2018-09-14 14:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 14:36 Serge Petrenko [this message]
2018-09-14 14:36 ` [PATCH 1/2] tarantoolctl: fix cat and play for empty body requests Serge Petrenko
2018-09-14 15:37 ` Vladimir Davydov
2018-09-14 14:36 ` [PATCH 2/2] recovery: fix incorrect handling of empty-body requests Serge Petrenko
2018-09-14 16:27 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1536934854.git.sergepetrenko@tarantool.org \
--to=sergepetrenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [PATCH 0/2] fix bodiless requests handling.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox