From: Kirill Shcherbatov <kshcherbatov@tarantool.org> To: tarantool-patches@freelists.org Cc: korablev@tarantool.org, Kirill Shcherbatov <kshcherbatov@tarantool.org> Subject: [tarantool-patches] [PATCH v1 0/3] sql: dissallow bindings for DDL Date: Fri, 31 Aug 2018 18:45:39 +0300 [thread overview] Message-ID: <cover.1535730218.git.kshcherbatov@tarantool.org> (raw) Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3653-no-bindings-on-ddl Issue: https://github.com/tarantool/tarantool/issues/3653 Bindings could not be used in stored ACTs because they allocate memory registers and makes assignments on parse sequentially. Original sqlite3 did validations that persistent AST doesn't have auto-assigment Varibles on triggers and checks creation. On DDL integration complete we've get rid this mechanism. Now it should be returned. Also fixed memory leak on error in sql_*_compile functions and double free with sql_check_list_item_init. Kirill Shcherbatov (3): sql: fix sql_check_list_item_init double free sql: fix sql_*_compile functions leak on error sql: dissallow bindings for DDL src/box/space_def.c | 3 ++- src/box/sql.c | 5 ++--- src/box/sql/parse.y | 6 +++++- src/box/sql/prepare.c | 1 - src/box/sql/tokenize.c | 9 ++++----- test/sql-tap/check.test.lua | 4 ++-- test/sql/checks.result | 45 ++++++++++++++++++++++++++++++++++++++++++++- test/sql/checks.test.lua | 18 +++++++++++++++++- 8 files changed, 76 insertions(+), 15 deletions(-) -- 2.7.4
next reply other threads:[~2018-08-31 15:45 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-31 15:45 Kirill Shcherbatov [this message] 2018-08-31 15:45 ` [tarantool-patches] [PATCH v1 1/3] sql: fix sql_check_list_item_init double free Kirill Shcherbatov 2018-08-31 15:45 ` [tarantool-patches] [PATCH v1 2/3] sql: fix sql_*_compile functions leak on error Kirill Shcherbatov 2018-08-31 15:45 ` [tarantool-patches] [PATCH v1 3/3] sql: dissallow bindings for DDL Kirill Shcherbatov 2018-09-04 11:00 ` [tarantool-patches] " n.pettik 2018-09-06 13:04 ` Kirill Shcherbatov 2018-09-10 21:52 ` n.pettik 2018-09-11 7:21 ` Kirill Shcherbatov 2018-09-11 23:03 ` n.pettik 2018-09-13 6:13 ` Kirill Shcherbatov 2018-09-13 10:12 ` [tarantool-patches] Re: [PATCH v1 0/3] " Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1535730218.git.kshcherbatov@tarantool.org \ --to=kshcherbatov@tarantool.org \ --cc=korablev@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [tarantool-patches] [PATCH v1 0/3] sql: dissallow bindings for DDL' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox